Added license, tests, and updated readme

Author: null93

LICENSE.md

@@ -0,0 +1,21 @@
+# The MIT License (MIT)
+Copyright 2024-present Rafael Grigorian
+
+* * *
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of
+this software and associated documentation files (the "Software"), to deal in
+the Software without restriction, including without limitation the rights to
+use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
+the Software, and to permit persons to whom the Software is furnished to do so,
+subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
+IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

README.md

@@ -10,10 +10,10 @@ Once you copy the `.so` file to the PHP extensions directory, you can enable it
 
 ```ini
 extension=nop.so
-nop.ignore_functions=chmod,chown
+nop.functions=chmod,chown
 ```
 
-Notice that `nop.ignore_functions` is a comma-separated list of functions that you want to replace with the NOP function.
+Notice that `nop.functions` is a comma-separated list of functions that you want to replace with the NOP function.
 
 ## Development
 
@@ -29,16 +29,11 @@ Inside the container, run the following commands:
 # Install build dependencies and build the extension
 apk --update add php83-dev make g++
 phpize && ./configure && make && make install
+make test
 
-# Setup a quick test
-touch ./private/sample
-echo "<?php chmod(__DIR__ . '/sample', 0777);" > ./private/sample.php
-
-# Run the test
-chmod 644 ./private/sample
-ls -la ./private/sample
-php -d 'extension=nop.so' -d 'nop.ignore_functions=chmod' ./private/sample.php
-ls -la ./private/sample
+# Manually test functionality
+php -d 'extension=nop.so' -d 'nop.functions=' -r 'printf ("hi\n");'
+php -d 'extension=nop.so' -d 'nop.functions=printf' -r 'printf ("hi\n");'
 ```
 
 ## Additional Resources

nop.c

@@ -17,7 +17,7 @@
 #endif
 
 ZEND_BEGIN_MODULE_GLOBALS(nop)
-    char *ignore_functions;
+    char *functions;
 ZEND_END_MODULE_GLOBALS(nop)
 
 ZEND_DECLARE_MODULE_GLOBALS(nop)
@@ -30,7 +30,7 @@ ZEND_DECLARE_MODULE_GLOBALS(nop)
 
 static void php_nop_init_globals(zend_nop_globals *nop_globals)
 {
-    nop_globals->ignore_functions = NULL;
+    nop_globals->functions = NULL;
 }
 
 PHP_FUNCTION(no_operation)
@@ -50,7 +50,7 @@ PHP_RINIT_FUNCTION(nop)
 /* }}} */
 
 PHP_INI_BEGIN()
-    STD_PHP_INI_ENTRY("nop.ignore_functions", "", PHP_INI_ALL, OnUpdateString, ignore_functions, zend_nop_globals, nop_globals)
+    STD_PHP_INI_ENTRY("nop.functions", "", PHP_INI_ALL, OnUpdateString, functions, zend_nop_globals, nop_globals)
 PHP_INI_END()
 
 /* {{{ PHP_MINIT_FUNCTION */
@@ -59,10 +59,10 @@ PHP_MINIT_FUNCTION(nop)
     ZEND_INIT_MODULE_GLOBALS(nop, php_nop_init_globals, NULL);
 	REGISTER_INI_ENTRIES();
 
-	char *ignore_functions = NOP_G(ignore_functions);
-	if (ignore_functions != NULL) {
+	char *functions = NOP_G(functions);
+	if (functions != NULL) {
 		char *token;
-		char *rest = ignore_functions;
+		char *rest = functions;
 		while ((token = strtok_r(rest, ",", &rest))) {
 			zend_function *original;
 			original = zend_hash_str_find_ptr(CG(function_table), token, strlen(token));

tests/003.phpt

@@ -0,0 +1,10 @@
+--TEST--
+functions=
+--EXTENSIONS--
+nop
+--FILE--
+<?php
+printf("Hello, World!\n");
+?>
+--EXPECT--
+Hello, World!

tests/004.phpt

@@ -0,0 +1,12 @@
+--TEST--
+functions=printf
+--EXTENSIONS--
+nop
+--INI--
+nop.functions=printf
+--FILE--
+<?php
+printf("Hello, World!\n");
+?>
+--EXPECT--
+