-
-
Notifications
You must be signed in to change notification settings - Fork 63
CI Improvements for testing images #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
antonym
commented
Dec 6, 2025
- Drop forced chown during copy
- Bumping to latest Alpine
- Adding PR Template
1ebd588 to
fa1606d
Compare
🚀 Test Image Built Successfully!Your PR test images have been published and are ready for testing: Docker Hubdocker pull netbootxyz/netbootxyz:pr-116GitHub Container Registrydocker pull ghcr.io/netbootxyz/netbootxyz:pr-116Quick Test CommandsStandard Docker: docker run -d \
--name netbootxyz-test \
-e PUID=1000 \
-e PGID=1000 \
-p 3000:3000 \
-p 69:69/udp \
-p 8080:80 \
-v /local/path/config:/config \
netbootxyz/netbootxyz:pr-116Rootless Podman (with NFS): podman run -d \
--name netbootxyz-test \
-e PUID=1000 \
-e PGID=1000 \
-p 3000:3000 \
-p 69:69/udp \
-p 8080:80 \
-v /nfs/path/config:/config \
netbootxyz/netbootxyz:pr-116Platforms
Check Logsdocker logs -f netbootxyz-test📦 SHA: |
* Drop forced chown during copy * Adding PR Template
fa1606d to
4884908
Compare
🚀 Test Image Built Successfully!Your PR test images have been published and are ready for testing: Docker Hubdocker pull netbootxyz/netbootxyz:pr-116GitHub Container Registrydocker pull ghcr.io/netbootxyz/netbootxyz:pr-116Quick Test CommandsStandard Docker: docker run -d \
--name netbootxyz-test \
-e PUID=1000 \
-e PGID=1000 \
-p 3000:3000 \
-p 69:69/udp \
-p 8080:80 \
-v /local/path/config:/config \
netbootxyz/netbootxyz:pr-116Platforms
Check Logsdocker logs -f netbootxyz-test📦 SHA: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the CI/CD pipeline for building and testing Docker images with improved workflows and testing capabilities.
- Adds workflow_dispatch support with custom tag suffixes for manual test image builds
- Removes forced chown during COPY operation and updates Alpine base image initialization
- Introduces a comprehensive PR template with testing checklists and environment details
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Dockerfile | Adds Alpine baselayout initialization and removes --chown flag from COPY operation for better compatibility |
| .github/workflows/build.yml | Extends build workflow to support both PR and manual dispatch events, adds automated PR commenting with test instructions, and modifies Trivy scanner configuration |
| .github/pull_request_template.md | New template providing structured sections for PR description, testing environments, platforms, and checklists |
Comments suppressed due to low confidence (1)
Dockerfile:57
- The package
busyboxis installed twice - once on line 53 and again on line 57. This is redundant and should be removed from one of these locations (likely line 57 since it's already being installed withalpine-baselayouton line 53).
RUN apk --initdb add --no-cache alpine-baselayout busybox
RUN apk add --no-cache \
# Core utilities
bash \
busybox \
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "IS_PR=false" >> $GITHUB_ENV | ||
| fi | ||
| - name: Build and push PR test image |
Copilot
AI
Dec 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The step name "Build and push PR test image" is misleading as this step now handles both pull request and workflow_dispatch events (for test images). Consider renaming to something more generic like "Build and push test image".
| - name: Build and push PR test image | |
| - name: Build and push test image |
| image-ref: 'ghcr.io/netbootxyz/netbootxyz:${{ env.TAG_SUFFIX }}' | ||
| format: 'table' | ||
| exit-code: '1' | ||
| exit-code: '0' |
Copilot
AI
Dec 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the Trivy exit-code from '1' to '0' means that the workflow will no longer fail when CRITICAL or HIGH severity vulnerabilities are found. This significantly weakens security posture for test images. Consider if this change is intentional, or if there should be a conditional exit-code based on the event type (e.g., fail for PRs but warn for manual dispatches).