Skip to content

Commit 770090b

Browse files
committed
Add aria-label to select elements (#346)
1 parent 3b4d070 commit 770090b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/partials/nav-cheat-sheet.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{{#if (eq page.attributes.theme 'cheat-sheet') }}
22
<div class="nav-panel-types{{#unless page.navigation}} is-active{{/unless}}" data-panel="explore" data-selector-type="products">
33
<div class="dropdown">
4-
<select id="cheat-sheet-selector-products" class="cs-selector dropdown-styles" data-label-type="products">
4+
<select aria-label="Product" id="cheat-sheet-selector-products" class="cs-selector dropdown-styles" data-label-type="products">
55
{{!-- <option value="all" data-label="all" data-class="all" data-label-type="products">All</option> --}}
66
{{#each page.attributes.cheatsheet-products}}
77
{{#if this.default}}
@@ -23,7 +23,7 @@
2323
<div class="nav-panel-types{{#unless page.navigation}} is-active{{/unless}}" data-panel="explore" data-selector-type="categories">
2424
{{!-- categories - eg read, write, structure, general --}}
2525
<div class="dropdown">
26-
<select id="cheat-sheet-selector-categories" class="cs-selector dropdown-styles" data-label-type="categories">
26+
<select aria-label="Cypher category" id="cheat-sheet-selector-categories" class="cs-selector dropdown-styles" data-label-type="categories">
2727
<option value="all" data-label="all" data-class="all" data-label-type="categories">All</option>
2828
{{#each page.attributes.cheatsheet-categories}}
2929
{{#if this.default}}

src/partials/nav-selectors.hbs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<div class="dropdown">
77
<span class="dropdown-label">{{#with (or page.attributes.cheatsheet-product 'Product')}}{{this}}{{/with}} Version</span>
88

9-
<select id="selector-version" data-current="{{@root.page.version}}" class="version-selector dropdown-styles">
9+
<select aria-label="Version" id="selector-version" data-current="{{@root.page.version}}" class="version-selector dropdown-styles">
1010
{{#each page.versions}}
1111
{{#unless (and this.prerelease @root.page.attributes.nav-selectors-hide-prerelease)}}
1212
<option
@@ -32,7 +32,7 @@
3232
<div class="selectors">
3333
<div class="nav-panel-types{{#unless page.navigation}} is-active{{/unless}}" data-panel="explore" data-selector-type="products">
3434
<div class="dropdown">
35-
<select id="cheat-sheet-selector-products" class="cs-selector dropdown-styles" data-label-type="products">
35+
<select aria-label="Product" id="cheat-sheet-selector-products" class="cs-selector dropdown-styles" data-label-type="products">
3636
{{!-- <option value="all" data-label="all" data-class="all" data-label-type="products">All</option> --}}
3737
{{#each page.attributes.cheatsheet-products}}
3838
{{#if this.default}}
@@ -54,7 +54,7 @@
5454
<div class="nav-panel-types{{#unless page.navigation}} is-active{{/unless}}" data-panel="explore" data-selector-type="categories">
5555
{{!-- categories - eg read, write, structure, general --}}
5656
<div class="dropdown">
57-
<select id="cheat-sheet-selector-categories" class="cs-selector dropdown-styles" data-label-type="categories">
57+
<select aria-label="Cypher category" id="cheat-sheet-selector-categories" class="cs-selector dropdown-styles" data-label-type="categories">
5858
<option value="all" data-label="all" data-class="all" data-label-type="categories">All</option>
5959
{{#each page.attributes.cheatsheet-categories}}
6060
{{#if this.default}}

0 commit comments

Comments
 (0)