Skip to content

Commit fab62f3

Browse files
author
Shahak Yosef
committed
Merged PR 63865: Remove Bower, use models 1.3.2 and update sdk to 2.10.4
Remove bower and update dist file. Should mirror [this PR](https://github.com/microsoft/PowerBI-JavaScript/pull/359/files) to JS API Github repository
1 parent 680331c commit fab62f3

File tree

13 files changed

+80
-102
lines changed

13 files changed

+80
-102
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
node_modules/
2-
bower_components/
32
coverage/
43
docs
54
typings/

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ The build and tests use webpack to compile all the source modules into one bundl
5858
## Running the demo
5959
Navigate to `/demo` directory
6060

61-
Install bower dependencies:
61+
Install npm dependencies:
6262
```
63-
bower install
63+
npm install
6464
```
6565

6666
Serve the demo directory:

README.md

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ JavaScript library for embedding Power BI into your apps.
33

44
[![Build Status](https://img.shields.io/travis/Microsoft/PowerBI-JavaScript/master.svg)](https://travis-ci.org/Microsoft/PowerBI-JavaScript)
55
[![NPM Version](https://img.shields.io/npm/v/powerbi-client.svg)](https://www.npmjs.com/package/powerbi-client)
6-
[![Bower Version](https://img.shields.io/bower/v/powerbi-client.svg)](https://bower.io/search/?q=powerbi-client)
76
[![Nuget Version](https://img.shields.io/nuget/v/Microsoft.PowerBI.JavaScript.svg)](https://www.nuget.org/packages/Microsoft.PowerBI.JavaScript/)
87
[![NPM Total Downloads](https://img.shields.io/npm/dt/powerbi-client.svg)](https://www.npmjs.com/package/powerbi-client)
98
[![NPM Monthly Downloads](https://img.shields.io/npm/dm/powerbi-client.svg)](https://www.npmjs.com/package/powerbi-client)
@@ -29,10 +28,6 @@ Install from NPM:
2928

3029
`npm install --save powerbi-client`
3130

32-
Install from Bower:
33-
34-
`bower install powerbi-client --save`
35-
3631
Installing beta versions:
3732

3833
`npm install --save powerbi-client@beta`
@@ -48,7 +43,7 @@ import * as pbi from 'powerbi-client';
4843
However, the library is exported as a Universal Module and the powerbi.js script can be included before your app's closing `</body>` tag as:
4944

5045
```html
51-
<script src="/bower_components/powerbi-client/dist/powerbi.js"></script>
46+
<script src="/powerbi-client/dist/powerbi.js"></script>
5247
```
5348

5449
When included directly, the library is exposed as a global named `powerbi-client`.

bower.json

Lines changed: 0 additions & 30 deletions
This file was deleted.

demo/bower.json

Lines changed: 0 additions & 26 deletions
This file was deleted.

demo/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
"ignore": [
2626
"**/.*",
2727
"node_modules",
28-
"bower_components",
2928
"test",
3029
"tests"
3130
],

dist/powerbi-client.d.ts

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! powerbi-client v2.10.3 | (c) 2016 Microsoft Corporation MIT */
1+
/*! powerbi-client v2.10.4 | (c) 2016 Microsoft Corporation MIT */
22
declare module "util" {
33
import { HttpPostMessage } from 'http-post-message';
44
/**
@@ -77,10 +77,18 @@ declare module "util" {
7777
* Checks if the embed url is for RDL report.
7878
*
7979
* @export
80-
* @param {string} embedUrl
81-
* @returns {boolean}
80+
* @param {string} embedUrl
81+
* @returns {boolean}
8282
*/
8383
export function isRDLEmbed(embedUrl: string): boolean;
84+
/**
85+
* Checks if the embed url contains autoAuth=true.
86+
*
87+
* @export
88+
* @param {string} embedUrl
89+
* @returns {boolean}
90+
*/
91+
export function autoAuthInEmbedUrl(embedUrl: string): boolean;
8492
/**
8593
* Returns random number
8694
*/
@@ -100,6 +108,10 @@ declare module "defaults" {
100108
static defaultQnaSettings: models.IQnaSettings;
101109
}
102110
}
111+
declare module "errors" {
112+
export let APINotSupportedForRDLError: string;
113+
export let EmbedUrlNotSupported: string;
114+
}
103115
declare module "embed" {
104116
import * as service from "service";
105117
import * as models from 'powerbi-models';
@@ -495,9 +507,6 @@ declare module "embed" {
495507
private frontLoadSendConfig(config);
496508
}
497509
}
498-
declare module "errors" {
499-
export let APINotSupportedForRDLError: string;
500-
}
501510
declare module "ifilterable" {
502511
import * as models from 'powerbi-models';
503512
/**

dist/powerbi.js

Lines changed: 53 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/powerbi.min.js

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "powerbi-client",
3-
"version": "2.10.3",
3+
"version": "2.10.4",
44
"description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",
55
"main": "dist/powerbi.js",
66
"typings": "dist/powerbi-client.d.ts",
@@ -74,7 +74,7 @@
7474
},
7575
"dependencies": {
7676
"http-post-message": "^0.2",
77-
"powerbi-models": "^1.3.1",
77+
"powerbi-models": "^1.3",
7878
"powerbi-router": "^0.1",
7979
"window-post-message-proxy": "^0.2"
8080
},

0 commit comments

Comments
 (0)