Skip to content

Commit a64989f

Browse files
committed
Fix bug when multiple embeds have no or duplicated element id
This bug caused multiple embeds to break when the elements had no id or duplicated ids. This broke event handling and some interaction features. Change Service.addOrOverwriteEmbed algorithm that compared elements by their id so that it now directly compares elements reference equality. Expand the service init test to include three different tests covering initialization of multiple embeds with different element id configurations (with id, without id*, with duplicated id*) * These two tests will fail without the fix applied to service.ts
1 parent c586a5e commit a64989f

File tree

4 files changed

+77
-17
lines changed

4 files changed

+77
-17
lines changed

dist/powerbi.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)