Skip to content

Commit 8fbf7bd

Browse files
author
Prachi Mishra (Maq LLC)
committed
Merged PR 76458: [JS SDK]: Description update
| Check | Yes/No/NA | |:------|:------:| |Are the packages re-created? |Yes| |Are the unit tests executed successfully? |Yes| |Is the code formatted correctly? |Yes| ![image.png](https://powerbi.visualstudio.com/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/1dd63332-e003-46a3-ac6f-70213a1bcc2e/pullRequests/76458/attachments/image.png) Updated documentation - https://review.docs.microsoft.com/en-us/javascript/powerbi-client/?branch=smoke-source-working Related work items: #331924, #353668, #364744, #375381
1 parent 272015b commit 8fbf7bd

File tree

17 files changed

+80
-71
lines changed

17 files changed

+80
-71
lines changed

demo/v2-demo/scripts/codesamples.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -786,7 +786,7 @@ function _Embed_QnaEmbed() {
786786
// Read question from textbox
787787
var txtQuestion = $('#txtQuestion').val();
788788

789-
// Read Qna mode
789+
// Read Q&A mode
790790
var qnaMode = $("input[name='qnaMode']:checked").val();
791791

792792
// Get models. models contains enums that can be used.
@@ -825,7 +825,7 @@ function _Embed_QnaEmbed_Aad() {
825825
// Read question from textbox
826826
var txtQuestion = $('#txtQuestion').val();
827827

828-
// Read Qna mode
828+
// Read Q&A mode
829829
var qnaMode = $("input[name='qnaMode']:checked").val();
830830

831831
// Get models. models contains enums that can be used.

dist/powerbi-client.d.ts

Lines changed: 26 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ declare module "config" {
103103
export default config;
104104
}
105105
declare module "defaults" {
106-
/** @ignore */ /** */
107106
import * as models from 'powerbi-models';
108107
/** @hidden */
109108
export abstract class Defaults {
@@ -179,7 +178,7 @@ declare module "embed" {
179178
visualName: string;
180179
}
181180
/**
182-
* Configuration settings for Power BI QNA embed component
181+
* Configuration settings for Power BI Q&A embed component
183182
*
184183
* @export
185184
* @interface IEmbedConfiguration
@@ -321,7 +320,7 @@ declare module "embed" {
321320
* datasetId: '5dac7a4a-4452-46b3-99f6-a25915e0fe55',
322321
* accessToken: 'eyJ0eXA ... TaE2rTSbmg',
323322
* ```
324-
*
323+
* @hidden
325324
* @param {models.IReportCreateConfiguration} config
326325
* @returns {Promise<void>}
327326
*/
@@ -372,7 +371,7 @@ declare module "embed" {
372371
* })
373372
* .catch(error => { ... });
374373
* ```
375-
*
374+
* @hidden
376375
* @param {models.ILoadConfiguration} config
377376
* @param {boolean} phasedRender
378377
* @returns {Promise<void>}
@@ -526,6 +525,8 @@ declare module "embed" {
526525
private isFullscreen(iframe);
527526
/**
528527
* Validate load and create configuration.
528+
*
529+
* @hidden
529530
*/
530531
abstract validate(config: IEmbedConfigurationBase): models.IError[];
531532
/**
@@ -563,7 +564,6 @@ declare module "embed" {
563564
}
564565
}
565566
declare module "ifilterable" {
566-
/** @ignore */ /** */
567567
import * as models from 'powerbi-models';
568568
/**
569569
* Decorates embed components that support filters
@@ -595,7 +595,6 @@ declare module "ifilterable" {
595595
}
596596
}
597597
declare module "visualDescriptor" {
598-
/** @ignore */ /** */
599598
import * as models from 'powerbi-models';
600599
import { IFilterable } from "ifilterable";
601600
import { IPageNode } from "page";
@@ -742,7 +741,6 @@ declare module "visualDescriptor" {
742741
}
743742
}
744743
declare module "page" {
745-
/** @ignore */ /** */
746744
import { IFilterable } from "ifilterable";
747745
import { IReportNode } from "report";
748746
import { VisualDescriptor } from "visualDescriptor";
@@ -898,7 +896,6 @@ declare module "page" {
898896
}
899897
}
900898
declare module "report" {
901-
/** @ignore */ /** */
902899
import * as service from "service";
903900
import * as embed from "embed";
904901
import * as models from 'powerbi-models';
@@ -954,11 +951,10 @@ declare module "report" {
954951
* (e.g. http://embedded.powerbi.com/appTokenReportEmbed?reportId=854846ed-2106-4dc2-bc58-eb77533bf2f1).
955952
*
956953
* By extracting the ID we can ensure that the ID is always explicitly provided as part of the load configuration.
957-
*
954+
* @hidden
958955
* @static
959956
* @param {string} url
960957
* @returns {string}
961-
* @hidden
962958
*/
963959
static findIdFromEmbedUrl(url: string): string;
964960
/**
@@ -1115,6 +1111,8 @@ declare module "report" {
11151111
updateSettings(settings: models.ISettings): Promise<void>;
11161112
/**
11171113
* Validate load configuration.
1114+
*
1115+
* @hidden
11181116
*/
11191117
validate(config: embed.IEmbedConfigurationBase): models.IError[];
11201118
/**
@@ -1183,7 +1181,6 @@ declare module "report" {
11831181
}
11841182
}
11851183
declare module "create" {
1186-
/** @ignore */ /** */
11871184
import * as service from "service";
11881185
import * as models from 'powerbi-models';
11891186
import * as embed from "embed";
@@ -1209,6 +1206,7 @@ declare module "create" {
12091206
/**
12101207
* Handle config changes.
12111208
*
1209+
* @hidden
12121210
* @returns {void}
12131211
*/
12141212
configChanged(isBootstrap: boolean): void;
@@ -1236,12 +1234,12 @@ declare module "create" {
12361234
* @static
12371235
* @param {string} url
12381236
* @returns {string}
1237+
* @hidden
12391238
*/
12401239
static findIdFromEmbedUrl(url: string): string;
12411240
}
12421241
}
12431242
declare module "dashboard" {
1244-
/** @ignore */ /** */
12451243
import * as service from "service";
12461244
import * as embed from "embed";
12471245
import * as models from 'powerbi-models';
@@ -1287,7 +1285,7 @@ declare module "dashboard" {
12871285
* E.g. https://powerbi-df.analysis-df.windows.net/dashboardEmbedHost?dashboardId=e9363c62-edb6-4eac-92d3-2199c5ca2a9e
12881286
*
12891287
* By extracting the id we can ensure id is always explicitly provided as part of the load configuration.
1290-
*
1288+
* @hidden
12911289
* @static
12921290
* @param {string} url
12931291
* @returns {string}
@@ -1301,6 +1299,8 @@ declare module "dashboard" {
13011299
getId(): string;
13021300
/**
13031301
* Validate load configuration.
1302+
*
1303+
* @hidden
13041304
*/
13051305
validate(baseConfig: embed.IEmbedConfigurationBase): models.IError[];
13061306
/**
@@ -1322,7 +1322,6 @@ declare module "dashboard" {
13221322
}
13231323
}
13241324
declare module "tile" {
1325-
/** @ignore */ /** */
13261325
import * as service from "service";
13271326
import * as models from 'powerbi-models';
13281327
import * as embed from "embed";
@@ -1367,6 +1366,7 @@ declare module "tile" {
13671366
* Adds the ability to get tileId from url.
13681367
* By extracting the ID we can ensure that the ID is always explicitly provided as part of the load configuration.
13691368
*
1369+
* @hidden
13701370
* @static
13711371
* @param {string} url
13721372
* @returns {string}
@@ -1375,12 +1375,11 @@ declare module "tile" {
13751375
}
13761376
}
13771377
declare module "qna" {
1378-
/** @ignore */ /** */
13791378
import * as service from "service";
13801379
import * as models from 'powerbi-models';
13811380
import * as embed from "embed";
13821381
/**
1383-
* The Power BI Qna embed component
1382+
* The Power BI Q&A embed component
13841383
*
13851384
* @export
13861385
* @class Qna
@@ -1396,7 +1395,7 @@ declare module "qna" {
13961395
*/
13971396
constructor(service: service.Service, element: HTMLElement, config: embed.IEmbedConfigurationBase, phasedRender?: boolean, isBootstrap?: boolean);
13981397
/**
1399-
* The ID of the Qna embed component
1398+
* The ID of the Q&A embed component
14001399
*
14011400
* @returns {string}
14021401
*/
@@ -1426,7 +1425,6 @@ declare module "qna" {
14261425
}
14271426
}
14281427
declare module "visual" {
1429-
/** @ignore */ /** */
14301428
import * as service from "service";
14311429
import * as embed from "embed";
14321430
import * as models from 'powerbi-models';
@@ -1519,7 +1517,6 @@ declare module "visual" {
15191517
}
15201518
}
15211519
declare module "service" {
1522-
/** @ignore */ /** */
15231520
import * as embed from "embed";
15241521
import * as wpmp from 'window-post-message-proxy';
15251522
import * as hpm from 'http-post-message';
@@ -1636,6 +1633,7 @@ declare module "service" {
16361633
* @param {HTMLElement} [container]
16371634
* @param {embed.IEmbedConfiguration} [config=undefined]
16381635
* @returns {embed.Embed[]}
1636+
* @hidden
16391637
*/
16401638
init(container?: HTMLElement, config?: embed.IEmbedConfiguration): embed.Embed[];
16411639
/**
@@ -1666,8 +1664,11 @@ declare module "service" {
16661664
* @param {embed.IBootstrapEmbedConfiguration} config: a bootstrap config which is an embed config without access token.
16671665
*/
16681666
bootstrap(element: HTMLElement, config: embed.IBootstrapEmbedConfiguration): embed.Embed;
1667+
/** @hidden */
16691668
embedInternal(element: HTMLElement, config?: embed.IEmbedConfigurationBase, phasedRender?: boolean, isBootstrap?: boolean): embed.Embed;
1669+
/** @hidden */
16701670
getNumberOfComponents(): number;
1671+
/** @hidden */
16711672
getSdkSessionId(): string;
16721673
/**
16731674
* Given a configuration based on a Power BI element, saves the component instance that reference the element for later lookup.
@@ -1695,6 +1696,8 @@ declare module "service" {
16951696
*
16961697
* Note: Only runs if `config.autoEmbedOnContentLoaded` is true when the service is created.
16971698
* This handler is typically useful only for applications that are rendered on the server so that all required data is available when the handler is called.
1699+
*
1700+
* @hidden
16981701
*/
16991702
enableAutoEmbed(): void;
17001703
/**
@@ -1709,6 +1712,7 @@ declare module "service" {
17091712
*
17101713
* @param {string} uniqueId
17111714
* @returns {(Report | Tile)}
1715+
* @hidden
17121716
*/
17131717
find(uniqueId: string): embed.Embed;
17141718
/**
@@ -1717,6 +1721,7 @@ declare module "service" {
17171721
* @param {Embed} component
17181722
* @param {HTMLElement} element
17191723
* @returns {void}
1724+
* @hidden
17201725
*/
17211726
addOrOverwriteEmbed(component: embed.Embed, element: HTMLElement): void;
17221727
/**
@@ -1730,6 +1735,7 @@ declare module "service" {
17301735
* handles tile events
17311736
*
17321737
* @param {IEvent<any>} event
1738+
* @hidden
17331739
*/
17341740
handleTileEvents(event: IEvent<any>): void;
17351741
/**
@@ -1752,12 +1758,11 @@ declare module "service" {
17521758
}
17531759
}
17541760
declare module "bookmarksManager" {
1755-
/** @ignore */ /** */
17561761
import * as service from "service";
17571762
import * as embed from "embed";
17581763
import * as models from 'powerbi-models';
17591764
/**
1760-
* Report bookmarks management APIs.
1765+
* APIs for managing the report bookmarks.
17611766
*
17621767
* @export
17631768
* @interface IBookmarksManager
@@ -1845,7 +1850,6 @@ declare module "factories" {
18451850
/**
18461851
* TODO: Need to find better place for these factory functions or refactor how we handle dependency injection
18471852
*/
1848-
/** @ignore */ /** */
18491853
import { IHpmFactory, IWpmpFactory, IRouterFactory } from "service";
18501854
export { IHpmFactory, IWpmpFactory, IRouterFactory };
18511855
export const hpmFactory: IHpmFactory;

0 commit comments

Comments
 (0)