Skip to content

Commit 5157b61

Browse files
committed
Merged PR 139121: Fix powerbi.reset to remove all event handlers
## In this PR: - Fix powerbi.reset to remove all event handlers - Resolves [Bug 510340](https://dev.azure.com/powerbi/Embedded/_workitems/edit/510340): [Power BI JS SDK]: Reset command doesn't clear the registered events of the removed artifact from the container Related work items: #510340, #510902
1 parent ce34d4c commit 5157b61

File tree

6 files changed

+16
-7
lines changed

6 files changed

+16
-7
lines changed

dist/powerbi-client.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! powerbi-client v2.17.0 | (c) 2016 Microsoft Corporation MIT */
1+
/*! powerbi-client v2.17.1 | (c) 2016 Microsoft Corporation MIT */
22
declare module "util" {
33
import { HttpPostMessage } from 'http-post-message';
44
/**

dist/powerbi.js

Lines changed: 6 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/powerbi.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "powerbi-client",
3-
"version": "2.17.0",
3+
"version": "2.17.1",
44
"description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",
55
"main": "dist/powerbi.js",
66
"types": "dist/powerbi-client.d.ts",

src/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/** @ignore *//** */
22
const config = {
3-
version: '2.17.0',
3+
version: '2.17.1',
44
type: 'js'
55
};
66

src/service.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -497,6 +497,11 @@ export class Service implements IService {
497497
embedElement.element.removeEventListener('ready', embedElement.frontLoadHandler, false);
498498
}
499499

500+
/** Removes all event handlers. */
501+
embedElement.allowedEvents.forEach(eventName => {
502+
embedElement.off(eventName);
503+
});
504+
500505
/** Removes the component from an internal list of components. */
501506
utils.remove(x => x === powerBiElement.powerBiEmbed, this.embeds);
502507
/** Deletes a property from the HTML element. */

0 commit comments

Comments
 (0)