Attempt to merge two fixes and three new features (custom async token storage, userReady flag, loginWithCustomHandler) #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix: race condition that might break a resuming session (meteorrn#164) - add option.AsyncTokenStorage (eg. for using expos SecureStorage) - add userReady() method to determine, if the initial user object finished loading - add loginWithCustomHandler to be able to call custom Meteor loginHandlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
for my app I came up with a few tweaks for this package and I try to realign my changes with the master branch of this package again. I tested the features in my staging env, no issues so far. I'll open this as a draft so we can discuss if we want to merge this into master.
Summary
Linked issue(s)
Fixes #164
Involved parts of the project
User.js and Meteor.js mainly
Added tests?
no additional tests so far