Give the music lab some love #933
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented some of the things I had in mind. Some changes may be more "controversial" than others so I'm prepared to cherry pick the commits.
TO-DO list:
scala fmtimportstuffThere are a lot of places where objects are fully qualified. I think it would be more readable if they were imported.
math.floorModwhen calculatingrelativePitchClassesFor example change "relative pitch classes" to "simple intervals".
Some names are (in my opinion) unnecessarily compressed. Whilst I can accept the use of single letter names (at least outside of public API), I would like to change
nbrOf*andto*OpttonumberOf*andto*Optionto align with the naming instd.enums in place ofIntsThere is a nauseatingly high usage of integers throughout the lab for things that should be
enums. On one hand it could prompt students to refactor the api themselves. On the other hand we should encourage the use ofenums and in my my experience most people are quite cautious when it comes to changing the given code.The compendium needs to be updated to reflect (some of) the above changes.
scalafmtoutput and remove potential regressions in readability