Skip to content

Branch names are not url encoded #1059

@taylor-schneider

Description

@taylor-schneider

Describe the bug
The UI is not URL encoding branch names which leads to invalid URLs. For example, if the git repo has a branch named "feature/blah=blah" the UI will construct a url that contains "feature/blah-blah" rather than "feature%2fblah-blah"

To Reproduce
Steps to reproduce the behavior:

  1. Open website
  2. Try to view notebook in branch with special char in name (e.g. this notebook)

Expected behavior
The note book should load rather than send a 404

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 124.0.6367.201

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:BugAn unexpected behavior

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions