From f0cb46933d50f88203f88423c9719b0f15dfd2b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Noco=C5=84?= Date: Tue, 16 Dec 2025 21:40:05 +0100 Subject: [PATCH] Fixed PHPStan issues --- .../src/Command/FindUrlCommand.php | 2 +- .../MySuggestionEventSubscriber.php | 2 +- .../siteaccess/AcmeExampleExtension.php | 2 +- .../BlockEmbedEventEventSubscriber.php | 1 + .../src/Block/Listener/MyBlockListener.php | 1 + .../src/Event/RandomBlockListener.php | 1 + phpstan-baseline.neon | 30 ------------------- 7 files changed, 6 insertions(+), 33 deletions(-) diff --git a/code_samples/api/public_php_api/src/Command/FindUrlCommand.php b/code_samples/api/public_php_api/src/Command/FindUrlCommand.php index 082834e250..d9535189b3 100644 --- a/code_samples/api/public_php_api/src/Command/FindUrlCommand.php +++ b/code_samples/api/public_php_api/src/Command/FindUrlCommand.php @@ -49,7 +49,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int $results = $this->urlService->findUrls($query); foreach ($results->items as $result) { - $output->writeln($result->url); + $output->writeln($result->getUrl()); } return self::SUCCESS; diff --git a/code_samples/back_office/search/src/EventSubscriber/MySuggestionEventSubscriber.php b/code_samples/back_office/search/src/EventSubscriber/MySuggestionEventSubscriber.php index 9fe69380df..05fe585da8 100644 --- a/code_samples/back_office/search/src/EventSubscriber/MySuggestionEventSubscriber.php +++ b/code_samples/back_office/search/src/EventSubscriber/MySuggestionEventSubscriber.php @@ -37,7 +37,7 @@ public function onBuildSuggestionCollectionEvent(BuildSuggestionCollectionEvent try { $productQuery = new ProductQuery(null, new Criterion\LogicalOr([ - new Criterion\ProductName(implode(' ', array_map(static fn (string $word) => "$word*", $words))), + new Criterion\ProductName(implode(' ', array_map(static fn (string $word): string => "$word*", $words))), new Criterion\ProductCode($words), new Criterion\ProductType($words), ]), [], 0, $limit); diff --git a/code_samples/multisite/siteaccess/AcmeExampleExtension.php b/code_samples/multisite/siteaccess/AcmeExampleExtension.php index 230b330026..47de70ea6c 100644 --- a/code_samples/multisite/siteaccess/AcmeExampleExtension.php +++ b/code_samples/multisite/siteaccess/AcmeExampleExtension.php @@ -29,7 +29,7 @@ public function load(array $configs, ContainerBuilder $container): void $config, // Any kind of callable can be used here. // It is called for each declared scope/SiteAccess. - static function ($scopeSettings, $currentScope, ContextualizerInterface $contextualizer) { + static function ($scopeSettings, $currentScope, ContextualizerInterface $contextualizer): void { // Maps the "name" setting to "acme_example.<$currentScope>.name" container parameter // It is then possible to retrieve this parameter through ConfigResolver in the application code: // $helloSetting = $configResolver->getParameter( 'name', 'acme_example' ); diff --git a/code_samples/page/custom_page_block/src/Event/Subscriber/BlockEmbedEventEventSubscriber.php b/code_samples/page/custom_page_block/src/Event/Subscriber/BlockEmbedEventEventSubscriber.php index 157c55ced7..408be0db42 100644 --- a/code_samples/page/custom_page_block/src/Event/Subscriber/BlockEmbedEventEventSubscriber.php +++ b/code_samples/page/custom_page_block/src/Event/Subscriber/BlockEmbedEventEventSubscriber.php @@ -22,6 +22,7 @@ public static function getSubscribedEvents(): array public function onBlockPreRender(PreRenderEvent $event): void { + /** @var \Ibexa\FieldTypePage\FieldType\Page\Block\Renderer\Twig\TwigRenderRequest $renderRequest */ $renderRequest = $event->getRenderRequest(); $parameters = $event->getRenderRequest()->getParameters(); $parameters['event_content'] = $this->contentService->loadContent($parameters['event']); diff --git a/code_samples/page/page_listener/src/Block/Listener/MyBlockListener.php b/code_samples/page/page_listener/src/Block/Listener/MyBlockListener.php index 716cba8645..00f0884efb 100644 --- a/code_samples/page/page_listener/src/Block/Listener/MyBlockListener.php +++ b/code_samples/page/page_listener/src/Block/Listener/MyBlockListener.php @@ -17,6 +17,7 @@ public static function getSubscribedEvents(): array public function onBlockPreRender(PreRenderEvent $event): void { + /** @var \Ibexa\FieldTypePage\FieldType\Page\Block\Renderer\Twig\TwigRenderRequest $renderRequest */ $renderRequest = $event->getRenderRequest(); $parameters = $event->getRenderRequest()->getParameters(); diff --git a/code_samples/tutorials/page_tutorial/src/Event/RandomBlockListener.php b/code_samples/tutorials/page_tutorial/src/Event/RandomBlockListener.php index 8d04f283fb..04d20d6b93 100644 --- a/code_samples/tutorials/page_tutorial/src/Event/RandomBlockListener.php +++ b/code_samples/tutorials/page_tutorial/src/Event/RandomBlockListener.php @@ -33,6 +33,7 @@ public static function getSubscribedEvents(): array public function onBlockPreRender(PreRenderEvent $event): void { $blockValue = $event->getBlockValue(); + /** @var \Ibexa\FieldTypePage\FieldType\Page\Block\Renderer\Twig\TwigRenderRequest $renderRequest */ $renderRequest = $event->getRenderRequest(); $parameters = $renderRequest->getParameters(); diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 458db81aba..f0376d016f 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -60,12 +60,6 @@ parameters: count: 3 path: code_samples/api/public_php_api/src/Command/CreateContentTypeCommand.php - - - message: '#^Access to protected property Ibexa\\Contracts\\Core\\Repository\\Values\\URL\\URL\:\:\$url\.$#' - identifier: property.protected - count: 1 - path: code_samples/api/public_php_api/src/Command/FindUrlCommand.php - - message: '#^Argument of an invalid type Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Search\\AggregationResult supplied for foreach, only iterables are supported\.$#' identifier: foreach.nonIterable @@ -606,24 +600,12 @@ parameters: count: 1 path: code_samples/page/custom_page_block/src/Event/Subscriber/BlockEmbedEventEventSubscriber.php - - - message: '#^Call to an undefined method Ibexa\\FieldTypePage\\FieldType\\Page\\Block\\Renderer\\RenderRequestInterface\:\:setParameters\(\)\.$#' - identifier: method.notFound - count: 1 - path: code_samples/page/custom_page_block/src/Event/Subscriber/BlockEmbedEventEventSubscriber.php - - message: '#^Call to an undefined method Ibexa\\FieldTypePage\\FieldType\\Page\\Block\\Renderer\\RenderRequestInterface\:\:getParameters\(\)\.$#' identifier: method.notFound count: 1 path: code_samples/page/page_listener/src/Block/Listener/MyBlockListener.php - - - message: '#^Call to an undefined method Ibexa\\FieldTypePage\\FieldType\\Page\\Block\\Renderer\\RenderRequestInterface\:\:setParameters\(\)\.$#' - identifier: method.notFound - count: 1 - path: code_samples/page/page_listener/src/Block/Listener/MyBlockListener.php - - message: '#^Parameter \#1 \$criteria of class Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Query\\Criterion\\LogicalAnd constructor expects array\, array\ given\.$#' identifier: argument.type @@ -666,18 +648,6 @@ parameters: count: 1 path: code_samples/search/custom/src/Query/SortClause/Elasticsearch/ScoreVisitor.php - - - message: '#^Call to an undefined method Ibexa\\FieldTypePage\\FieldType\\Page\\Block\\Renderer\\RenderRequestInterface\:\:getParameters\(\)\.$#' - identifier: method.notFound - count: 1 - path: code_samples/tutorials/page_tutorial/src/Event/RandomBlockListener.php - - - - message: '#^Call to an undefined method Ibexa\\FieldTypePage\\FieldType\\Page\\Block\\Renderer\\RenderRequestInterface\:\:setParameters\(\)\.$#' - identifier: method.notFound - count: 1 - path: code_samples/tutorials/page_tutorial/src/Event/RandomBlockListener.php - - message: '#^Cannot call method getValue\(\) on Ibexa\\Contracts\\FieldTypePage\\FieldType\\LandingPage\\Model\\Attribute\|null\.$#' identifier: method.nonObject