Remove dead fixmes

Differential Revision: D13526574

Reviewed By: dneiter

fbshipit-source-id: eda7dee8754180b545e4f59a3ac36f1128859d3a

Author: DavidSnider

src/ColoredUnifiedDiff.php

@@ -112,11 +112,7 @@ final public static function create(
           $next = Str\slice($next, 1);
           $lines = Vec\drop($lines, 1);
 
-          /* HH_IGNORE_ERROR[4107] using directly because this is open source */
-          /* HH_IGNORE_ERROR[2049] using directly because this is open source */
           $words_line = vec(\preg_split('/([^a-zA-Z0-9_]+)/', $line, -1, \PREG_SPLIT_DELIM_CAPTURE));
-          /* HH_IGNORE_ERROR[4107] using directly because this is open source */
-          /* HH_IGNORE_ERROR[2049] using directly because this is open source */
           $words_next = vec(\preg_split('/([^a-zA-Z0-9_]+)/', $next, -1, \PREG_SPLIT_DELIM_CAPTURE));
           $intraline = (new StringDiff($words_line, $words_next))->getDiff();
           $out[] = $intraline

tests/StringDiffTest.php

@@ -61,17 +61,11 @@ public function provideExamples(): vec<varray<string>> {
   <<DataProvider('provideExamples')>>
   public function testUnifiedDiff(string $name): void {
     $base = __DIR__.'/examples/'.$name;
-    /* HH_IGNORE_ERROR[4107] using directly because this is open source */
-    /* HH_IGNORE_ERROR[2049] using directly because this is open source */
     $a = \file_get_contents($base.'.a');
-    /* HH_IGNORE_ERROR[4107] using directly because this is open source */
-    /* HH_IGNORE_ERROR[2049] using directly because this is open source */
     $b = \file_get_contents($base.'.b');
     $diff = StringDiff::lines($a, $b)->getUnifiedDiff();
 
     expect($diff)->toBeSame(
-      /* HH_IGNORE_ERROR[4107] using directly because this is open source */
-      /* HH_IGNORE_ERROR[2049] using directly because this is open source */
       \file_get_contents($base.'.udiff.expect'),
       'Did not match expected contents '.
       '(from diff -u %s.a %s.b | tail -n +3 > %s.udiff.expect)',
@@ -84,11 +78,7 @@ public function testUnifiedDiff(string $name): void {
   <<DataProvider('provideExamples')>>
   public function testCLIColoredDiff(string $name): void {
     $base = __DIR__.'/examples/'.$name;
-    /* HH_IGNORE_ERROR[4107] using directly because this is open source */
-    /* HH_IGNORE_ERROR[2049] using directly because this is open source */
     $a = \file_get_contents($base.'.a');
-    /* HH_IGNORE_ERROR[4107] using directly because this is open source */
-    /* HH_IGNORE_ERROR[2049] using directly because this is open source */
     $b = \file_get_contents($base.'.b');
     $diff = CLIColoredUnifiedDiff::create($a, $b);
 
@@ -107,8 +97,6 @@ public function testCLIColoredDiff(string $name): void {
     }
 
     expect($diff)->toBeSame(
-      /* HH_IGNORE_ERROR[4107] using directly because this is open source */
-      /* HH_IGNORE_ERROR[2049] using directly because this is open source */
       \file_get_contents($base.'.clidiff.expect'),
       'Did not match expected contents (- %s.clidiff.expect, + %s.clidiff.out)',
       $base,