Don't keep patches in memory

Author: ericmj

lib/diff_web/live/diff_live_view.ex

@@ -45,23 +45,12 @@ defmodule DiffWeb.DiffLiveView do
           </div>
         <% end %>
 
-        <%= if @search_query != "" do %>
-          <div class="search-form">
-            <input
-              class="search-input"
-              type="text"
-              placeholder="Search files..."
-              phx-keyup="search"
-              phx-debounce="300"
-              value={@search_query}
-            />
-          </div>
-        <% end %>
+
 
         <div class="ghd-container" id="patch-list">
           <%= for patch_id <- @loaded_patches do %>
             <div id={"patch-#{patch_id}"}>
-              <%= raw(Map.get(@patch_contents, patch_id, "")) %>
+              <%= raw(load_patch_content(@package, @from, @to, patch_id)) %>
             </div>
           <% end %>
 
@@ -152,10 +141,8 @@ defmodule DiffWeb.DiffLiveView do
         all_patch_ids: patch_ids,
         loaded_patches: initial_patches,
         remaining_patches: remaining,
-        patch_contents: %{},
         loading: true,
         generating: false,
-        search_query: "",
         has_more_patches: length(remaining) > 0
       )
 
@@ -175,10 +162,8 @@ defmodule DiffWeb.DiffLiveView do
         all_patch_ids: [],
         loaded_patches: [],
         remaining_patches: [],
-        patch_contents: %{},
         loading: false,
         generating: true,
-        search_query: "",
         has_more_patches: false
       )
 
@@ -221,30 +206,6 @@ defmodule DiffWeb.DiffLiveView do
     {:noreply, socket}
   end
 
-  def handle_event("search", %{"value" => query}, socket) do
-    filtered_patches =
-      if query == "" do
-        socket.assigns.all_patch_ids
-      else
-        Enum.filter(socket.assigns.all_patch_ids, fn patch_id ->
-          case Map.get(socket.assigns.patch_contents, patch_id) do
-            nil -> false
-            content -> String.contains?(String.downcase(content), String.downcase(query))
-          end
-        end)
-      end
-
-    socket =
-      assign(socket,
-        search_query: query,
-        loaded_patches: Enum.take(filtered_patches, 10),
-        remaining_patches: Enum.drop(filtered_patches, 10),
-        has_more_patches: length(filtered_patches) > 10
-      )
-
-    {:noreply, socket}
-  end
-
   def handle_info({:generate_diff, package, from, to}, socket) do
     case Diff.Hex.diff(package, from, to) do
       {:ok, stream} ->
@@ -283,66 +244,24 @@ defmodule DiffWeb.DiffLiveView do
   end
 
   def handle_info({:load_patches_and_update, patch_ids}, socket) do
-    %{package: package, from: from, to: to} = socket.assigns
-
-    loaded_contents =
-      patch_ids
-      |> Enum.reduce(%{}, fn patch_id, acc ->
-        case Diff.Storage.get_patch(package, from, to, patch_id) do
-          {:ok, content} ->
-            sanitized_content = sanitize_utf8(content)
-            Map.put(acc, patch_id, sanitized_content)
-
-          {:error, reason} ->
-            Logger.error("Failed to load patch #{patch_id}: #{inspect(reason)}")
-            Map.put(acc, patch_id, "<div class='patch-error'>Failed to load patch</div>")
-        end
-      end)
-
-    # Update BOTH loaded_patches AND patch_contents in ONE DOM update
+    # Simply add new patches to loaded_patches - no server memory management needed
+    # Patches are loaded on-demand during rendering from storage
     new_loaded_patches = socket.assigns.loaded_patches ++ patch_ids
 
     socket =
       socket
       |> assign(
         loaded_patches: new_loaded_patches,
-        patch_contents: Map.merge(socket.assigns.patch_contents, loaded_contents),
         loading: false
       )
 
     {:noreply, socket}
   end
 
-  def handle_info({:load_patches, patch_ids}, socket) do
-    %{package: package, from: from, to: to} = socket.assigns
-
-    Logger.info("📦 Actually loading patch content for: #{inspect(patch_ids)}")
-
-    loaded_contents =
-      patch_ids
-      |> Enum.reduce(%{}, fn patch_id, acc ->
-        case Diff.Storage.get_patch(package, from, to, patch_id) do
-          {:ok, content} ->
-            # Ensure content is valid UTF-8 to prevent JSON encoding errors
-            sanitized_content = sanitize_utf8(content)
-            Logger.info("✅ Successfully loaded patch #{patch_id} (#{byte_size(content)} bytes)")
-            Map.put(acc, patch_id, sanitized_content)
-
-          {:error, reason} ->
-            Logger.error("❌ Failed to load patch #{patch_id}: #{inspect(reason)}")
-            Map.put(acc, patch_id, "<div class='patch-error'>Failed to load patch</div>")
-        end
-      end)
-
-    Logger.info("🎯 Loaded #{map_size(loaded_contents)} patches, updating socket assigns")
-
-    socket =
-      socket
-      |> assign(
-        patch_contents: Map.merge(socket.assigns.patch_contents, loaded_contents),
-        loading: false
-      )
-
+  def handle_info({:load_patches, _patch_ids}, socket) do
+    # With on-demand loading, we just need to mark loading as complete
+    # Patch content will be loaded during rendering
+    socket = assign(socket, loading: false)
     {:noreply, socket}
   end
 
@@ -496,6 +415,16 @@ defmodule DiffWeb.DiffLiveView do
 
   defp sanitize_utf8(content), do: content
 
+  defp load_patch_content(package, from, to, patch_id) do
+    case Diff.Storage.get_patch(package, from, to, patch_id) do
+      {:ok, content} ->
+        sanitize_utf8(content)
+
+      {:error, _reason} ->
+        "<div class='patch-error'>Failed to load patch</div>"
+    end
+  end
+
   defp parse_diff(diff) do
     case String.split(diff, ":", trim: true) do
       [app, from, to] -> {app, from, to, build_url(app, from, to)}