Switch mailers to SES

[24c02]

loops delenda est......
until zach decides it's loops again

[sentry]

Bug: The IdentityMailer.v2_login_code call in step_up_controller.rb passes two arguments, but the mailer method now expects only one.
_{Severity: CRITICAL | Confidence: High}

🔍 Detailed Analysis

The IdentityMailer.v2_login_code method is called with two arguments (current_identity, login_code) in step_up_controller.rb's send_step_up_email_code method. However, the updated mailer method now expects only one argument (login_code). This mismatch will cause an ArgumentError: wrong number of arguments (given 2, expected 1) when users attempt to use email-based verification in the step-up authentication flow, leading to a critical application crash.

💡 Suggested Fix

Update the call to IdentityMailer.v2_login_code in step_up_controller.rb to pass only the login_code argument. The identity can be accessed via login_code.identity within the mailer.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: app/controllers/step_up_controller.rb#L109-L115

Potential issue: The `IdentityMailer.v2_login_code` method is called with two arguments
(`current_identity`, `login_code`) in `step_up_controller.rb`'s
`send_step_up_email_code` method. However, the updated mailer method now expects only
one argument (`login_code`). This mismatch will cause an `ArgumentError: wrong number of
arguments (given 2, expected 1)` when users attempt to use email-based verification in
the step-up authentication flow, leading to a critical application crash.

_{Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 5637289}