Skip to content

chore: Use js api over _Binaryen api for types #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spotandjake wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Use js api over _Binaryen api for types #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function caml_binaryen_type_structref() {
//Provides: caml_binaryen_type_arrayref
//Requires: Binaryen
function caml_binaryen_type_arrayref() {
// TODO: Binaryen v111 didn't expose this directly
// TODO: Binaryen v125 doesn't expose this directly
return Binaryen._BinaryenTypeArrayref();
}

Expand All @@ -80,22 +80,19 @@ function caml_binaryen_type_stringref() {
//Provides: caml_binaryen_type_nullref
//Requires: Binaryen
function caml_binaryen_type_nullref() {
// TODO: Binaryen v111 didn't expose this directly
return Binaryen._BinaryenTypeNullref();
return Binaryen.nullref;
}

//Provides: caml_binaryen_type_null_externref
//Requires: Binaryen
function caml_binaryen_type_null_externref() {
// TODO: Binaryen v111 didn't expose this directly
return Binaryen._BinaryenTypeNullExternref();
return Binaryen.nullexternref;
}

//Provides: caml_binaryen_type_null_funcref
//Requires: Binaryen
function caml_binaryen_type_null_funcref() {
// TODO: Binaryen v111 didn't expose this directly
return Binaryen._BinaryenTypeNullFuncref();
return Binaryen.nullfuncref;
}

//Provides: caml_binaryen_type_unreachable
Expand Down