Skip to content

Commit aad8b0a

Browse files
committed
delete return from Run method
1 parent fd7086e commit aad8b0a

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

app.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,20 +52,24 @@ func New(config ...Config) *Pulse {
5252
return app
5353
}
5454

55-
func (f *Pulse) Run(address string) error {
56-
handler := RouterHandler(f.router)
55+
func (f *Pulse) Run(address string) {
56+
handler := RouterHandler(f.Router)
5757
f.server.Handler = handler
5858

5959
// setup listener
6060
listener, err := net.Listen(f.config.Network, address)
6161
if err != nil {
62-
return fmt.Errorf("failed to listen: %v", err)
62+
panic(fmt.Errorf("failed to listen: %v", err))
6363
}
6464

6565
// print startup message
6666
fmt.Println(f.startupMessage(listener.Addr().String()))
6767

68-
return f.server.Serve(listener)
68+
// start server
69+
err = f.server.Serve(listener)
70+
if err != nil {
71+
panic(fmt.Errorf("failed to serve: %v", err))
72+
}
6973
}
7074

7175
func (f *Pulse) startupMessage(addr string) string {

app_test.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,5 @@ func init() {
1313
}
1414

1515
func TestPulse_Run(t *testing.T) {
16-
err := app.Run("127.0.0.1:8082")
17-
if err != nil {
18-
return
19-
}
16+
app.Run("127.0.0.1:8082")
2017
}

0 commit comments

Comments
 (0)