Skip to content

Commit 68128b3

Browse files
owen-mcowen-mc
committed
Expected test changes (odd because post update nodes are still at the def)
1 parent ad0b836 commit 68128b3

File tree

3 files changed

+32
-30
lines changed

3 files changed

+32
-30
lines changed

‎go/ql/test/query-tests/Security/CWE-078/CommandInjection.expected‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ edges
4848
| GitSubcommands.go:11:13:11:27 | call to Query | GitSubcommands.go:17:36:17:42 | tainted | provenance | |
4949
| GitSubcommands.go:33:13:33:19 | selection of URL | GitSubcommands.go:33:13:33:27 | call to Query | provenance | Src:MaD:2 MaD:7 |
5050
| GitSubcommands.go:33:13:33:27 | call to Query | GitSubcommands.go:38:32:38:38 | tainted | provenance | |
51+
| SanitizingDoubleDash.go:9:2:9:8 | definition of tainted | SanitizingDoubleDash.go:13:25:13:31 | tainted | provenance | |
52+
| SanitizingDoubleDash.go:9:2:9:8 | definition of tainted | SanitizingDoubleDash.go:14:23:14:33 | slice expression | provenance | |
53+
| SanitizingDoubleDash.go:9:2:9:8 | definition of tainted | SanitizingDoubleDash.go:39:31:39:37 | tainted | provenance | Config |
54+
| SanitizingDoubleDash.go:9:2:9:8 | definition of tainted | SanitizingDoubleDash.go:52:24:52:30 | tainted | provenance | Config |
55+
| SanitizingDoubleDash.go:9:2:9:8 | definition of tainted | SanitizingDoubleDash.go:68:31:68:37 | tainted | provenance | Config |
56+
| SanitizingDoubleDash.go:9:2:9:8 | definition of tainted | SanitizingDoubleDash.go:80:23:80:29 | tainted | provenance | Config |
5157
| SanitizingDoubleDash.go:9:13:9:19 | selection of URL | SanitizingDoubleDash.go:9:13:9:27 | call to Query | provenance | Src:MaD:2 MaD:7 |
52-
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:13:25:13:31 | tainted | provenance | |
53-
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:14:23:14:33 | slice expression | provenance | |
54-
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:39:31:39:37 | tainted | provenance | |
55-
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:52:24:52:30 | tainted | provenance | |
56-
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:53:21:53:28 | arrayLit | provenance | |
57-
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:68:31:68:37 | tainted | provenance | |
58-
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:80:23:80:29 | tainted | provenance | |
58+
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:9:2:9:8 | definition of tainted | provenance | |
5959
| SanitizingDoubleDash.go:13:15:13:32 | array literal [array] | SanitizingDoubleDash.go:14:23:14:30 | arrayLit [array] | provenance | |
6060
| SanitizingDoubleDash.go:13:25:13:31 | tainted | SanitizingDoubleDash.go:13:15:13:32 | array literal [array] | provenance | |
6161
| SanitizingDoubleDash.go:14:23:14:30 | arrayLit [array] | SanitizingDoubleDash.go:14:23:14:33 | slice element node | provenance | |
@@ -67,6 +67,7 @@ edges
6767
| SanitizingDoubleDash.go:39:31:39:37 | tainted | SanitizingDoubleDash.go:39:14:39:44 | []type{args} [array] | provenance | |
6868
| SanitizingDoubleDash.go:52:15:52:31 | slice literal [array] | SanitizingDoubleDash.go:53:21:53:28 | arrayLit [array] | provenance | |
6969
| SanitizingDoubleDash.go:52:24:52:30 | tainted | SanitizingDoubleDash.go:52:15:52:31 | slice literal [array] | provenance | |
70+
| SanitizingDoubleDash.go:52:24:52:30 | tainted | SanitizingDoubleDash.go:53:21:53:28 | arrayLit | provenance | |
7071
| SanitizingDoubleDash.go:53:14:53:35 | call to append | SanitizingDoubleDash.go:54:23:54:30 | arrayLit | provenance | |
7172
| SanitizingDoubleDash.go:53:14:53:35 | call to append [array] | SanitizingDoubleDash.go:54:23:54:30 | arrayLit | provenance | |
7273
| SanitizingDoubleDash.go:53:21:53:28 | arrayLit | SanitizingDoubleDash.go:53:14:53:35 | call to append | provenance | MaD:4 |
@@ -180,6 +181,7 @@ nodes
180181
| GitSubcommands.go:33:13:33:19 | selection of URL | semmle.label | selection of URL |
181182
| GitSubcommands.go:33:13:33:27 | call to Query | semmle.label | call to Query |
182183
| GitSubcommands.go:38:32:38:38 | tainted | semmle.label | tainted |
184+
| SanitizingDoubleDash.go:9:2:9:8 | definition of tainted | semmle.label | definition of tainted |
183185
| SanitizingDoubleDash.go:9:13:9:19 | selection of URL | semmle.label | selection of URL |
184186
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | semmle.label | call to Query |
185187
| SanitizingDoubleDash.go:13:15:13:32 | array literal [array] | semmle.label | array literal [array] |

‎go/ql/test/query-tests/Security/CWE-078/SanitizingDoubleDash.go‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -93,62 +93,62 @@ func testDoubleDashIrrelevant(req *http.Request) {
9393

9494
{
9595
arrayLit := [1]string{tainted}
96-
exec.Command("sudo", arrayLit[:]...)
96+
exec.Command("sudo", arrayLit[:]...) // BAD
9797
}
9898

9999
{
100100
arrayLit := [2]string{"--", tainted}
101-
exec.Command("sudo", arrayLit[:]...)
101+
exec.Command("sudo", arrayLit[:]...) // BAD
102102
}
103103

104104
{
105105
arrayLit := []string{"--", tainted}
106-
exec.Command("sudo", arrayLit...)
106+
exec.Command("sudo", arrayLit...) // BAD
107107
}
108108

109109
{
110110
arrayLit := []string{}
111111
arrayLit = append(arrayLit, "--", tainted)
112-
exec.Command("sudo", arrayLit...)
112+
exec.Command("sudo", arrayLit...) // BAD
113113
}
114114

115115
{
116116
arrayLit := []string{}
117117
arrayLit = append(arrayLit, tainted, "--")
118-
exec.Command("sudo", arrayLit...)
118+
exec.Command("sudo", arrayLit...) // BAD
119119
}
120120

121121
{
122122
arrayLit := []string{"--"}
123123
arrayLit = append(arrayLit, tainted)
124-
exec.Command("sudo", arrayLit...)
124+
exec.Command("sudo", arrayLit...) // BAD
125125
}
126126

127127
{
128128
arrayLit := []string{tainted}
129129
arrayLit = append(arrayLit, "--")
130-
exec.Command("sudo", arrayLit...)
130+
exec.Command("sudo", arrayLit...) // BAD
131131
}
132132

133133
{
134134
arrayLit := []string{"--"}
135135
arrayLit = append(arrayLit, "something else")
136136
arrayLit = append(arrayLit, tainted)
137-
exec.Command("sudo", arrayLit...)
137+
exec.Command("sudo", arrayLit...) // BAD
138138
}
139139

140140
{
141141
arrayLit := []string{"something else"}
142142
arrayLit = append(arrayLit, tainted)
143143
arrayLit = append(arrayLit, "--")
144-
exec.Command("sudo", arrayLit...)
144+
exec.Command("sudo", arrayLit...) // BAD
145145
}
146146

147147
{
148-
exec.Command("sudo", "--", tainted)
148+
exec.Command("sudo", "--", tainted) // BAD
149149
}
150150

151151
{
152-
exec.Command("sudo", tainted, "--")
152+
exec.Command("sudo", tainted, "--") // BAD
153153
}
154154
}

‎go/ql/test/query-tests/Security/CWE-089/SqlInjection.expected‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -117,22 +117,22 @@ edges
117117
| main.go:61:5:61:15 | RequestData [pointer, Category] | main.go:61:4:61:15 | star expression [Category] | provenance | |
118118
| mongoDB.go:40:20:40:30 | call to Referer | mongoDB.go:42:28:42:41 | untrustedInput | provenance | Src:MaD:20 |
119119
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:50:34:50:39 | filter | provenance | |
120-
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:61:27:61:32 | filter | provenance | Sink:MaD:4 |
121-
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:63:23:63:28 | filter | provenance | Sink:MaD:5 |
122-
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:64:22:64:27 | filter | provenance | Sink:MaD:6 |
123-
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:66:32:66:37 | filter | provenance | Sink:MaD:7 |
124-
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:69:17:69:22 | filter | provenance | Sink:MaD:8 |
125-
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:70:20:70:25 | filter | provenance | Sink:MaD:9 |
126-
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:71:29:71:34 | filter | provenance | Sink:MaD:10 |
127-
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:72:30:72:35 | filter | provenance | Sink:MaD:11 |
128-
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:73:29:73:34 | filter | provenance | Sink:MaD:12 |
129-
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:78:23:78:28 | filter | provenance | Sink:MaD:13 |
130-
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:79:23:79:28 | filter | provenance | Sink:MaD:14 |
131-
| mongoDB.go:42:19:42:42 | struct literal | mongoDB.go:80:22:80:27 | filter | provenance | Sink:MaD:15 |
132120
| mongoDB.go:42:28:42:41 | untrustedInput | mongoDB.go:42:19:42:42 | struct literal | provenance | Config |
133121
| mongoDB.go:50:23:50:40 | struct literal | mongoDB.go:57:22:57:29 | pipeline | provenance | Sink:MaD:3 |
134122
| mongoDB.go:50:23:50:40 | struct literal | mongoDB.go:81:18:81:25 | pipeline | provenance | Sink:MaD:16 |
135123
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:50:23:50:40 | struct literal | provenance | Config |
124+
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:61:27:61:32 | filter | provenance | Sink:MaD:4 |
125+
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:63:23:63:28 | filter | provenance | Sink:MaD:5 |
126+
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:64:22:64:27 | filter | provenance | Sink:MaD:6 |
127+
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:66:32:66:37 | filter | provenance | Sink:MaD:7 |
128+
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:69:17:69:22 | filter | provenance | Sink:MaD:8 |
129+
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:70:20:70:25 | filter | provenance | Sink:MaD:9 |
130+
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:71:29:71:34 | filter | provenance | Sink:MaD:10 |
131+
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:72:30:72:35 | filter | provenance | Sink:MaD:11 |
132+
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:73:29:73:34 | filter | provenance | Sink:MaD:12 |
133+
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:78:23:78:28 | filter | provenance | Sink:MaD:13 |
134+
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:79:23:79:28 | filter | provenance | Sink:MaD:14 |
135+
| mongoDB.go:50:34:50:39 | filter | mongoDB.go:80:22:80:27 | filter | provenance | Sink:MaD:15 |
136136
models
137137
| 1 | Sink: database/sql; DB; true; Query; ; ; Argument[0]; sql-injection; manual |
138138
| 2 | Sink: database/sql; Tx; true; Query; ; ; Argument[0]; sql-injection; manual |

0 commit comments

Comments
 (0)