Skip to content

Integrate Gambit layout functionality #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edwardchalstrey1 merged 55 commits into from
Dec 3, 2025
Merged

Integrate Gambit layout functionality #17

edwardchalstrey1 merged 55 commits into from
Dec 3, 2025

Conversation

@edwardchalstrey1
Copy link
Member

@edwardchalstrey1 edwardchalstrey1 commented Dec 2, 2025 •
edited
Loading

  • This PR modifies draw_tree such that a Gambit game object from pygambit can be passed into the draw_tree function.
  • I will later update the pygambit docs showing how this works and link to it from the draw_tree README doc
  • pygambit remains an optional dependency.
  • Also adds LaTeX to the Github action so we can fully test functionality (via ensuring notebooks run without error)

@edwardchalstrey1
move DefaultLayout to layout.py
2a90e7b
@edwardchalstrey1
rename function that converts efg to ef with default layout
9005aea
@edwardchalstrey1
add players
1692a02
@edwardchalstrey1
get one line for each node
068392f
@edwardchalstrey1
separate node counter for each level of the tree
61495ea
@edwardchalstrey1
dont use sublevel for now
fe3801e
@edwardchalstrey1
label chance node as player 0
c23e155
@edwardchalstrey1
add initial verison of xshift vals
b3cdbbe
@edwardchalstrey1
remove xshift for root node
cd46e31
@edwardchalstrey1
get parent nodes
fbbcf03
@edwardchalstrey1
add moves
9a030d0
@edwardchalstrey1
add chance probabilities
5266e08
@edwardchalstrey1
add payoffs
1739130
@edwardchalstrey1
add infosets
500e0f2
@edwardchalstrey1
ignore sublevel for levels <= 1
c58c1fc
@edwardchalstrey1
ignore sublevel when node is not sharing an information set
12bab12
@edwardchalstrey1
import pygambit properly
fa734cc
@edwardchalstrey1
finish prev commit
34cead5
@edwardchalstrey1
add comments to gambit_layout_to_ef function
47a10c8
@edwardchalstrey1
Add gambit_layout_to_ef into generate_tikz
b2e15e8
@edwardchalstrey1
allow an output path to be passed for saving ef files
bec4029
@edwardchalstrey1
add comparisons for gambit layout
ba033e7
@edwardchalstrey1
compute child levels
5d93d6d
@edwardchalstrey1
remove try except and use if node.infoset in infoset_groups to check …
dafe5c6 
…for infoset presence
@edwardchalstrey1
tidy sublevel logic and comment
76ee366
@edwardchalstrey1
ensure child nodes have levels greater than their parents
907942a
@edwardchalstrey1
set LEVEL_MULTIPLIER
40a305a
@edwardchalstrey1
further improve node level logic
765b546
@edwardchalstrey1
handle player names with spaces by replacing spaces with tildes (~)
bc5309b
@edwardchalstrey1
handle cases where no outcomes are defined
fcedf05
@edwardchalstrey1
don't add player to node if in infoset with multiple nodes
6e22e77
@edwardchalstrey1
add XSHIFT_MULTIPLIER
171970b
@edwardchalstrey1
increase defealut level multiplier
127d728
@edwardchalstrey1
add SUBLEVEL_MULTIPLIER
9266477
@edwardchalstrey1
refactor: update gambit_layout_to_ef to use multipliers as parameters
b6493af
@edwardchalstrey1
add spacing args to draw_tree and generate_tikz functions
c15b19d
@edwardchalstrey1
mess around with sizing args
00da681
@edwardchalstrey1
fix: explicitly specify parameters in generate_tikz call
1f3a3c9
@edwardchalstrey1
fix: explicitly specify parameters in generate_tikz call
77ef273
@edwardchalstrey1
separate test notebooks
11ea4ba
@edwardchalstrey1
just load the generated ef file from draw_tree when running generate_…
45cff27 
…tex etc
@edwardchalstrey1
fix: add .ef files to .gitignore for tutorial dir
b29a64b
@edwardchalstrey1
switch output_path for save_to so that it can be a file path
e98bddf
@edwardchalstrey1
update draw_tree function docstring and rename arg from ef_file to game
0dcdd49
@edwardchalstrey1
add pygambit to test workflow
57ec92a
@edwardchalstrey1
add test that runs notebooks
efef8db
@edwardchalstrey1
update developer requirements and GitHub Actions test workflow to inc…
4268c0b 
…lude testing dependencies
@edwardchalstrey1 edwardchalstrey1 marked this pull request as ready for review December 3, 2025 11:43
@edwardchalstrey1 edwardchalstrey1 merged commit f3f3470 into main Dec 3, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Ed Chalstrey Gambit priorities Dec 3, 2025
@edwardchalstrey1 edwardchalstrey1 deleted the gambit-layout branch December 3, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edwardchalstrey1