From c0af8b3ce6fa053c598802aeb14fb64638b7c401 Mon Sep 17 00:00:00 2001 From: Gasol Wu Date: Sat, 9 Mar 2024 16:55:39 +0800 Subject: [PATCH] fix: Add scrollContainer to useEffect dependencies If we use useRef to reference the scrollContainer, we need to add it to the useEffect dependencies in order to reinitialize the event listener when the scrollContainer changes. Otherwise, the new scrollContainer will not have the event listener attached, and the scroll event will not be listened to. --- src/ScrollProvider.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ScrollProvider.js b/src/ScrollProvider.js index 1fff877..027e38d 100644 --- a/src/ScrollProvider.js +++ b/src/ScrollProvider.js @@ -56,7 +56,7 @@ const ScrollProvider = ({ scrollContainer.removeEventListener('scroll', onScroll, false); }; }, - [], + [scrollContainer], ); return (