Skip to content

Conversation

@cortinico
Copy link
Contributor

Summary:

We don't need to set the REACT_NATIVE_DEBUGGER_ENABLED for each target.
Instead we should be using the target_compile_reactnative_options CMake functiont that we already have.

Changelog:

[Internal] [Changed] -

Test Plan:

CI

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 4, 2025

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D88367612.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 Build Scan not published

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Job Summary for Gradle

Test All :: build_android
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github publishAllToMavenTempLocal build 9.0.0 Build Scan not published

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Job Summary for Gradle

Test All :: build_android
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github publishAllToMavenTempLocal build 9.0.0 Build Scan not published

@cortinico
Copy link
Contributor Author

/rebase

@cortinico cortinico force-pushed the nc/refactor-REACT_NATIVE_DEBUGGER_ENABLED branch from 07b5b9a to 7bff4c5 Compare December 5, 2025 10:01
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Job Summary for Gradle

Test All :: build_android
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github publishAllToMavenTempLocal build 9.0.0 Build Scan not published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants