Avoid warnings in suite that are now caught by the type system

Author: josevalim

lib/elixir/lib/kernel/special_forms.ex

@@ -1593,31 +1593,23 @@ defmodule Kernel.SpecialForms do
 
   Let's give it a try on IEx:
 
-      iex> opts = %{width: 10, height: 15}
-      iex> with {:ok, width} <- Map.fetch(opts, :width),
-      ...>      {:ok, height} <- Map.fetch(opts, :height) do
+      iex> opts = %{"width" => 10, "height" => 15}
+      iex> with {:ok, width} <- Map.fetch(opts, "width"),
+      ...>      {:ok, height} <- Map.fetch(opts, "height") do
       ...>   {:ok, width * height}
       ...> end
       {:ok, 150}
 
   If all clauses match, the `do` block is executed, returning its result.
   Otherwise the chain is aborted and the non-matched value is returned:
 
-      iex> opts = %{width: 10}
-      iex> with {:ok, width} <- Map.fetch(opts, :width),
-      ...>      {:ok, height} <- Map.fetch(opts, :height) do
+      iex> opts = %{"width" => 10}
+      iex> with {:ok, width} <- Map.fetch(opts, "width"),
+      ...>      {:ok, height} <- Map.fetch(opts, "height") do
       ...>   {:ok, width * height}
       ...> end
       :error
 
-  Guards can be used in patterns as well:
-
-      iex> users = %{"melany" => "guest", "bob" => :admin}
-      iex> with {:ok, role} when not is_binary(role) <- Map.fetch(users, "bob") do
-      ...>   {:ok, to_string(role)}
-      ...> end
-      {:ok, "admin"}
-
   As in `for/1`, variables bound inside `with/1` won't be accessible
   outside of `with/1`.
 
@@ -1661,22 +1653,18 @@ defmodule Kernel.SpecialForms do
   An `else` option can be given to modify what is being returned from
   `with` in the case of a failed match:
 
-      iex> opts = %{width: 10}
-      iex> with {:ok, width} <- Map.fetch(opts, :width),
-      ...>      {:ok, height} <- Map.fetch(opts, :height) do
-      ...>   {:ok, width * height}
-      ...> else
-      ...>   :error ->
-      ...>     {:error, :wrong_data}
-      ...>
-      ...>   _other_error ->
-      ...>     :unexpected_error
-      ...> end
-      {:error, :wrong_data}
+      with {:ok, content} <- File.read(path),
+           :ok <- File.write(path, [content, "!"]) do
+        :ok
+      else
+        {:error, reason} ->
+          Logger.error("could not append ! to \#{path} with reason: \#{reason}")
+          :error
+      end
 
   The `else` block works like a `case`: it can have multiple clauses,
-  and the first match will be used. Variables bound inside `with` (such as
-  `width` in this example) are not available in the `else` block.
+  and the first match will be used. Variables bound inside `with`
+  (such as `content` in this example) are not available in the `else` block.
 
   If an `else` block is used and there are no matching clauses, a `WithClauseError`
   exception is raised.

lib/elixir/lib/map.ex

@@ -301,7 +301,7 @@ defmodule Map do
 
       iex> Map.fetch(%{a: 1}, :a)
       {:ok, 1}
-      iex> Map.fetch(%{a: 1}, :b)
+      iex> Map.fetch(%{"foo" => "bar"}, "unknown")
       :error
 
   """
@@ -443,8 +443,8 @@ defmodule Map do
       iex> Map.replace!(%{a: 1, b: 2}, :a, 3)
       %{a: 3, b: 2}
 
-      iex> Map.replace!(%{a: 1}, :b, 2)
-      ** (KeyError) key :b not found in:
+      iex> Map.replace!(%{"foo" => "bar"}, "unknown", "new_bar")
+      ** (KeyError) key "unknown" not found in:
       ...
 
   """

lib/elixir/test/elixir/macro_test.exs

@@ -867,7 +867,7 @@ defmodule MacroTest do
     end
 
     test "with/1 (all clauses match)" do
-      opts = %{width: 10, height: 15}
+      opts = Process.get(:unused, %{width: 10, height: 15})
 
       {result, formatted} =
         dbg_format(
@@ -900,7 +900,7 @@ defmodule MacroTest do
     end
 
     test "with/1 (no else)" do
-      opts = %{width: 10}
+      opts = Process.get(:unused, %{width: 10})
 
       {result, formatted} =
         dbg_format(
@@ -928,7 +928,7 @@ defmodule MacroTest do
     end
 
     test "with/1 (else clause)" do
-      opts = %{width: 10}
+      opts = Process.get(:unused, %{width: 10})
 
       {result, formatted} =
         dbg_format(
@@ -959,7 +959,7 @@ defmodule MacroTest do
     end
 
     test "with/1 (guard)" do
-      opts = %{width: 10, height: 0.0}
+      opts = Process.get(:unused, %{width: 10, height: 0.0})
 
       {result, formatted} =
         dbg_format(
@@ -990,7 +990,7 @@ defmodule MacroTest do
     end
 
     test "with/1 (guard in else)" do
-      opts = %{}
+      opts = Process.get(:unused, %{})
 
       {result, _formatted} =
         dbg_format(

lib/elixir/test/elixir/map_test.exs

@@ -221,17 +221,13 @@ defmodule MapTest do
   end
 
   test "replace!/3" do
-    map = %{c: 3, b: 2, a: 1}
+    map = Process.get(:unused, %{c: 3, b: 2, a: 1})
     assert Map.replace!(map, :b, 10) == %{c: 3, b: 10, a: 1}
     assert Map.replace!(map, :a, 1) == map
 
     assert_raise KeyError, ~r/key :x not found in:\n\n    %{.*a: 1.*}/, fn ->
       Map.replace!(map, :x, 10)
     end
-
-    assert_raise KeyError, "key :x not found in:\n\n    %{}\n", fn ->
-      Map.replace!(%{}, :x, 10)
-    end
   end
 
   test "intersect/2" do