feat: rewrite in typescript #733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
force-pushed
the
sam/ts
branch
4 times, most recently
from
23123a0 to
9166b6e
Compare
dsanders11
reviewed
Jul 9, 2025
Member
dsanders11
left a comment
dsanders11
left a comment
There was a problem hiding this comment.
LGTM, but we'll need to rebase on main as a few PRs have landed since this was written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noting here for reviewers, this is not perfect, there's a few funky
ascasts, some annoying inconsistencies in import naming and grouping, etc. I want to land a base typescript thing that Works ™️ and then come back and clean it up, holding up the overall thing is just gonna make this impossible to land.This includes a shim that ensures the current version of
@electron/build-tools-installerkeeps working and pointseandsrc/e(shim) which redirects todist/e(real ESM thing)