[Backport 7.7] Clean spec folder before downloading a fresh copy (#4643)

github-actions[bot] · Mpdreamz · web-flow · commit 1e3884229f96 · 2020-04-21T10:48:45.000+02:00
Alternative approach to #4638, keeping it isolated to RestSpecDownloader Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
diff --git a/src/ApiGenerator/RestSpecDownloader.cs b/src/ApiGenerator/RestSpecDownloader.cs
@@ -38,6 +38,12 @@ private RestSpecDownloader(string branch)
 			{
 				foreach (var spec in specifications)
 				{
+					var specFolderOnDisk = Path.Combine(GeneratorLocations.RestSpecificationFolder, spec.FolderOnDisk);
+					if (Directory.Exists(specFolderOnDisk))
+					{
+						Directory.Delete(specFolderOnDisk, true);
+						pbar.WriteLine($"Deleted target spec folder, before downloading new copy: {specFolderOnDisk}");
+					}
 					pbar.Message = $"Downloading rest-api-spec to {spec.FolderOnDisk} for branch {branch}";
 					DownloadJsonDefinitions(spec, pbar);
 					pbar.Tick($"Downloaded rest-api-spec to {spec.FolderOnDisk} for branch {branch}");

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,12 @@ private RestSpecDownloader(string branch)`
`38`	`38`	`{`
`39`	`39`	`foreach (var spec in specifications)`
`40`	`40`	`{`
	`41`	`+ var specFolderOnDisk = Path.Combine(GeneratorLocations.RestSpecificationFolder, spec.FolderOnDisk);`
	`42`	`+ if (Directory.Exists(specFolderOnDisk))`
	`43`	`+ {`
	`44`	`+ Directory.Delete(specFolderOnDisk, true);`
	`45`	`+ pbar.WriteLine($"Deleted target spec folder, before downloading new copy: {specFolderOnDisk}");`
	`46`	`+ }`
`41`	`47`	`pbar.Message = $"Downloading rest-api-spec to {spec.FolderOnDisk} for branch {branch}";`
`42`	`48`	`DownloadJsonDefinitions(spec, pbar);`
`43`	`49`	`pbar.Tick($"Downloaded rest-api-spec to {spec.FolderOnDisk} for branch {branch}");`