Skip to content

Commit d1596ac

Browse files
committed
Revert build-tools to older version (#1279)
Change the build-tools artifact to an older version that still supports Java 8. Once the build versions have been updated, we can restore the build tools dependency to how it was before.
1 parent 650968b commit d1596ac

File tree

7 files changed

+22
-12
lines changed

7 files changed

+22
-12
lines changed

buildSrc/build.gradle

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,13 @@ apply plugin: 'groovy'
77
*/
88

99
boolean localRepo = project.getProperties().containsKey("localRepo")
10+
localRepo = false // TODO: Remove this once we can safely depend on build-tools again.
1011

1112
Properties props = new Properties()
1213
props.load(project.file('esh-version.properties').newDataInputStream())
1314
String eshVersion = props.getProperty('eshadoop')
1415
String esVersion = props.getProperty('elasticsearch')
16+
String buildToolsVersion = props.getProperty('build-tools') // TODO: Remove this once we can safely depend on build-tools again.
1517

1618
// determine if we're building a prerelease or candidate (alphaX/betaX/rcX)
1719
String qualifier = System.getProperty("build.version_qualifier", "")
@@ -58,9 +60,9 @@ dependencies {
5860
compile 'org.springframework.build.gradle:propdeps-plugin:0.0.7'
5961

6062
if (localRepo) {
61-
compile name: "build-tools-${esVersion}"
63+
compile name: "build-tools-${buildToolsVersion}"
6264
} else {
63-
compile group: 'org.elasticsearch.gradle', name: 'build-tools', version: esVersion
65+
compile group: 'org.elasticsearch.gradle', name: 'build-tools', version: buildToolsVersion
6466
}
6567
}
6668

buildSrc/esh-version.properties

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
eshadoop = 7.3.0
22
elasticsearch = 7.3.0
3+
lucene = 8.1.0-snapshot-e460356abe
4+
build-tools = 7.1.1

buildSrc/src/main/groovy/org/elasticsearch/hadoop/gradle/BuildPlugin.groovy

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import org.gradle.api.artifacts.DependencySubstitutions
1212
import org.gradle.api.artifacts.ResolutionStrategy
1313
import org.gradle.api.artifacts.maven.MavenPom
1414
import org.gradle.api.artifacts.maven.MavenResolver
15-
import org.gradle.api.artifacts.repositories.IvyArtifactRepository
1615
import org.gradle.api.file.CopySpec
1716
import org.gradle.api.java.archives.Manifest
1817
import org.gradle.api.plugins.JavaPlugin
@@ -91,13 +90,14 @@ class BuildPlugin implements Plugin<Project> {
9190
*/
9291
private static void configureVersions(Project project) {
9392
if (!project.rootProject.ext.has('versionsConfigured')) {
94-
project.rootProject.version = VersionProperties.ESHADOOP_VERSION
93+
project.rootProject.version = EshVersionProperties.ESHADOOP_VERSION
9594
println "Building version [${project.rootProject.version}]"
9695

97-
project.rootProject.ext.eshadoopVersion = VersionProperties.ESHADOOP_VERSION
98-
project.rootProject.ext.elasticsearchVersion = VersionProperties.ELASTICSEARCH_VERSION
99-
project.rootProject.ext.luceneVersion = org.elasticsearch.gradle.VersionProperties.lucene
100-
project.rootProject.ext.versions = VersionProperties.VERSIONS
96+
project.rootProject.ext.eshadoopVersion = EshVersionProperties.ESHADOOP_VERSION
97+
project.rootProject.ext.elasticsearchVersion = EshVersionProperties.ELASTICSEARCH_VERSION
98+
project.rootProject.ext.luceneVersion = EshVersionProperties.ELASTICSEARCH_VERSION
99+
project.rootProject.ext.buildToolsVersion = EshVersionProperties.BUILD_TOOLS_VERSION
100+
project.rootProject.ext.versions = EshVersionProperties.VERSIONS
101101
project.rootProject.ext.versionsConfigured = true
102102

103103
println "Testing against Elasticsearch [${project.rootProject.ext.elasticsearchVersion}] with Lucene [${project.rootProject.ext.luceneVersion}]"
@@ -127,6 +127,7 @@ class BuildPlugin implements Plugin<Project> {
127127
project.ext.eshadoopVersion = project.rootProject.ext.eshadoopVersion
128128
project.ext.elasticsearchVersion = project.rootProject.ext.elasticsearchVersion
129129
project.ext.luceneVersion = project.rootProject.ext.luceneVersion
130+
project.ext.buildToolsVersion = project.rootProject.ext.buildToolsVersion
130131
project.ext.versions = project.rootProject.ext.versions
131132
project.ext.hadoopVersion = project.rootProject.ext.hadoopVersion
132133
project.ext.hadoopClient = project.rootProject.ext.hadoopClient

buildSrc/src/main/groovy/org/elasticsearch/hadoop/gradle/VersionProperties.groovy renamed to buildSrc/src/main/groovy/org/elasticsearch/hadoop/gradle/EshVersionProperties.groovy

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,24 @@ package org.elasticsearch.hadoop.gradle
33
/**
44
* Loads the locally available version information from the build source.
55
*/
6-
class VersionProperties {
6+
class EshVersionProperties {
77

88
public static final String ESHADOOP_VERSION
99
public static final String ELASTICSEARCH_VERSION
10+
public static final String LUCENE_VERSION
11+
public static final String BUILD_TOOLS_VERSION
1012
public static final Map<String, String> VERSIONS
1113
static {
1214
Properties versionProperties = new Properties()
13-
InputStream propertyStream = VersionProperties.class.getResourceAsStream('/esh-version.properties')
15+
InputStream propertyStream = EshVersionProperties.class.getResourceAsStream('/esh-version.properties')
1416
if (propertyStream == null) {
1517
throw new RuntimeException("Could not locate the esh-version.properties file!")
1618
}
1719
versionProperties.load(propertyStream)
1820
ESHADOOP_VERSION = versionProperties.getProperty('eshadoop')
1921
ELASTICSEARCH_VERSION = versionProperties.getProperty('elasticsearch')
22+
LUCENE_VERSION = versionProperties.getProperty('lucene')
23+
BUILD_TOOLS_VERSION = versionProperties.getProperty('build-tools')
2024
VERSIONS = new HashMap<>()
2125
for (String propertyName: versionProperties.stringPropertyNames()) {
2226
VERSIONS.put(propertyName, versionProperties.getProperty(propertyName))

buildSrc/src/main/groovy/org/elasticsearch/hadoop/gradle/RootBuildPlugin.groovy

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import org.gradle.api.Project
66
import org.gradle.api.Task
77
import org.gradle.api.file.CopySpec
88
import org.gradle.api.file.DuplicatesStrategy
9-
import org.gradle.api.tasks.TaskInputs
109
import org.gradle.api.tasks.bundling.Jar
1110
import org.gradle.api.tasks.bundling.Zip
1211

qa/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ subprojects {
3232
// a local repo if we're currently in the release manager (unlikely, but be future proof).
3333
buildscript {
3434
boolean localRepo = project.getProperties().containsKey("localRepo")
35+
localRepo = false // TODO: Remove this once we can safely depend on build-tools again.
3536
repositories {
3637
jcenter()
3738
mavenCentral()
@@ -46,7 +47,7 @@ subprojects {
4647
if (localRepo) {
4748
classpath name: "build-tools-${version}"
4849
} else {
49-
classpath group: 'org.elasticsearch.gradle', name: 'build-tools', version: project.ext.elasticsearchVersion
50+
classpath group: 'org.elasticsearch.gradle', name: 'build-tools', version: project.ext.buildToolsVersion
5051
}
5152
}
5253
}

qa/kerberos/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ configurations {
4040
}
4141

4242
boolean localRepo = project.getProperties().containsKey("localRepo")
43+
localRepo = false // TODO: Remove this once we can safely depend on build-tools again.
4344

4445
dependencies {
4546
compile project(":elasticsearch-hadoop-mr")

0 commit comments

Comments
 (0)