Fix Gradle deprecation warnings (#1608)

This PR fixes deprecation warnings that will turn into errors
when migrating to gradle 7.0

- Enforce the build to fail when a deprecation occurs

Author: breskeby

buildSrc/build.gradle

@@ -65,16 +65,16 @@ repositories {
 }
 
 dependencies {
-    compile gradleApi()
-    compile localGroovy()
+    compileOnly gradleApi()
+    compileOnly localGroovy()
 
     if (localRepo) {
-        compile name: "build-tools-${buildToolsVersion}"
+        implementation name: "build-tools-${buildToolsVersion}"
         // Required for dependency licenses task (explicitly added in case of localRepo missing transitive dependencies)
-        compile group: 'commons-codec', name: 'commons-codec', version: '1.12'
-        compile group: 'org.apache.rat', name: 'apache-rat', version: '0.11'
+        implementation group: 'commons-codec', name: 'commons-codec', version: '1.12'
+        implementation group: 'org.apache.rat', name: 'apache-rat', version: '0.11'
     } else {
-        compile group: 'org.elasticsearch.gradle', name: 'build-tools', version: buildToolsVersion
+        implementation group: 'org.elasticsearch.gradle', name: 'build-tools', version: buildToolsVersion
     }
 }
 

buildSrc/src/main/groovy/org/elasticsearch/hadoop/gradle/BaseBuildPlugin.groovy

@@ -185,7 +185,7 @@ class BaseBuildPlugin implements Plugin<Project> {
         for (String repo : ['snapshots', 'artifacts']) {
             project.repositories.ivy {
                 url "https://${repo}.elastic.co/downloads"
-                layout "pattern", {
+                patternLayout {
                     artifact "elasticsearch/[module]-[revision](-[classifier]).[ext]"
                 }
                 // TODO: Forward Port

buildSrc/src/main/groovy/org/elasticsearch/hadoop/gradle/RootBuildPlugin.groovy

@@ -68,13 +68,13 @@ class RootBuildPlugin implements Plugin<Project> {
         Zip distZip = project.getTasks().create('distZip', Zip.class)
         distZip.dependsOn(project.getTasks().getByName('pack'))
         distZip.setGroup('Distribution')
-        distZip.setDescription("Builds -${distZip.getClassifier()} archive, containing all jars and docs, suitable for download page.")
+        distZip.setDescription("Builds -${distZip.archiveClassifier.get()} archive, containing all jars and docs, suitable for download page.")
 
         Task distribution = project.getTasks().getByName('distribution')
         distribution.dependsOn(distZip)
 
         // Location of the zip dir
-        project.rootProject.ext.folderName = "${distZip.baseName}" + "-" + "${project.version}"
+        project.rootProject.ext.folderName = "${distZip.archiveBaseName.get()}" + "-" + "${project.version}"
 
         // Copy root directory files to zip
         distZip.from(project.rootDir) { CopySpec spec ->

buildSrc/src/main/java/org/elasticsearch/hadoop/gradle/scala/SparkVariantPlugin.java

@@ -60,10 +60,10 @@
 import static org.gradle.api.plugins.JavaBasePlugin.VERIFICATION_GROUP;
 import static org.gradle.api.plugins.JavaPlugin.API_ELEMENTS_CONFIGURATION_NAME;
 import static org.gradle.api.plugins.JavaPlugin.COMPILE_CLASSPATH_CONFIGURATION_NAME;
-import static org.gradle.api.plugins.JavaPlugin.COMPILE_CONFIGURATION_NAME;
+// import static org.gradle.api.plugins.JavaPlugin.COMPILE_CONFIGURATION_NAME;
 import static org.gradle.api.plugins.JavaPlugin.IMPLEMENTATION_CONFIGURATION_NAME;
 import static org.gradle.api.plugins.JavaPlugin.RUNTIME_CLASSPATH_CONFIGURATION_NAME;
-import static org.gradle.api.plugins.JavaPlugin.RUNTIME_CONFIGURATION_NAME;
+// import static org.gradle.api.plugins.JavaPlugin.RUNTIME_CONFIGURATION_NAME;
 import static org.gradle.api.plugins.JavaPlugin.RUNTIME_ELEMENTS_CONFIGURATION_NAME;
 import static org.gradle.api.plugins.JavaPlugin.RUNTIME_ONLY_CONFIGURATION_NAME;
 import static org.gradle.api.plugins.JavaPlugin.TEST_TASK_NAME;
@@ -282,9 +282,9 @@ public void execute(ComponentMetadataContext componentMetadataContext) {
 
     // TODO: address deprecated configuration names
     private static List<String> TEST_CONFIGURATIONS_EXTENDED = Arrays.asList(
-            COMPILE_CONFIGURATION_NAME,
+           // TODO compile only
             IMPLEMENTATION_CONFIGURATION_NAME,
-            RUNTIME_CONFIGURATION_NAME,
+            // RUNTIME_CONFIGURATION_NAME,
             RUNTIME_ONLY_CONFIGURATION_NAME
     );
 

gradle.properties

@@ -1,3 +1,6 @@
+# Enforce the build to fail on deprecated gradle api usage
+systemProp.org.gradle.warning.mode=fail
+
 ## Settings
 org.gradle.daemon=false