fix: properly forward writef args

zaucy · zaucy · commit 761c150b5e65 · 2024-10-05T11:13:30.000-07:00
diff --git a/ecsact/codegen/plugin.hh b/ecsact/codegen/plugin.hh
@@ -163,7 +163,7 @@ struct codegen_plugin_context {
 
 	template<typename... Args>
 	auto writef(std::format_string<Args...> fmt, Args&&... args) {
-		auto str = std::format(fmt, std::forward(args)...);
+		auto str = std::format(fmt, std::forward<Args>(args)...);
 		write_(str.data(), static_cast<int32_t>(str.size()));
 	}
 
diff --git a/test/mock_plugin.cc b/test/mock_plugin.cc
@@ -34,4 +34,7 @@ auto ecsact_codegen_plugin( //
 	[[maybe_unused]] ecsact_codegen_write_fn_t  write_fn,
 	[[maybe_unused]] ecsact_codegen_report_fn_t report_fn
 ) -> void {
+	auto ctx = ecsact::codegen_plugin_context{package_id, 0, write_fn, report_fn};
+	auto world = std::string{"world"};
+	ctx.writef("hello {}", world);
 }

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ struct codegen_plugin_context {`
`163`	`163`
`164`	`164`	`template<typename... Args>`
`165`	`165`	`auto writef(std::format_string<Args...> fmt, Args&&... args) {`
`166`		`- auto str = std::format(fmt, std::forward(args)...);`
	`166`	`+ auto str = std::format(fmt, std::forward<Args>(args)...);`
`167`	`167`	`write_(str.data(), static_cast<int32_t>(str.size()));`
`168`	`168`	`}`
`169`	`169`
Original file line number	Diff line number	Diff line change
`@@ -34,4 +34,7 @@ auto ecsact_codegen_plugin( //`
`34`	`34`	`[[maybe_unused]] ecsact_codegen_write_fn_t write_fn,`
`35`	`35`	`[[maybe_unused]] ecsact_codegen_report_fn_t report_fn`
`36`	`36`	`) -> void {`
	`37`	`+ auto ctx = ecsact::codegen_plugin_context{package_id, 0, write_fn, report_fn};`
	`38`	`+ auto world = std::string{"world"};`
	`39`	`+ ctx.writef("hello {}", world);`
`37`	`40`	`}`