simplify tests for asserting private property

Author: mvorisek

tests/TokenizerTest.php

@@ -17,11 +17,23 @@
 
 final class TokenizerTest extends TestCase
 {
-    public function testKeywordsReservedAreUpperCasedAndWithoutWhitespace(): void
+    /**
+     * @param 'reserved'|'reservedToplevel'|'reservedNewline' $propertyName
+     *
+     * @return list<string>
+     */
+    private function getTokenizerList(string $propertyName): array
     {
         $tokenizerReflClass = new ReflectionClass(Tokenizer::class);
-        /** @var list<string> $tokenizerReserved */
-        $tokenizerReserved = $tokenizerReflClass->getProperty('reserved')->getDefaultValue();
+        /** @var list<string> $res */
+        $res = $tokenizerReflClass->getProperty($propertyName)->getDefaultValue();
+
+        return $res;
+    }
+
+    public function testKeywordsReservedAreUpperCasedAndWithoutWhitespace(): void
+    {
+        $tokenizerReserved = $this->getTokenizerList('reserved');
 
         $kwsDiff = array_filter($tokenizerReserved, static function ($v) {
             return $v !== strtoupper($v) || preg_match('~\s~', $v) !== 0;
@@ -32,25 +44,17 @@ public function testKeywordsReservedAreUpperCasedAndWithoutWhitespace(): void
 
     public function testKeywordsReservedToplevelAndNewlineAreReserved(): void
     {
-        $tokenizerReflClass = new ReflectionClass(Tokenizer::class);
-        /** @var list<string> $tokenizerReserved */
-        $tokenizerReserved = $tokenizerReflClass->getProperty('reserved')->getDefaultValue();
-        /** @var list<string> $tokenizerReservedToplevel */
-        $tokenizerReservedToplevel = $tokenizerReflClass->getProperty('reservedToplevel')->getDefaultValue();
-        /** @var list<string> $tokenizerReservedNewline */
-        $tokenizerReservedNewline = $tokenizerReflClass->getProperty('reservedNewline')->getDefaultValue();
+        $tokenizerReserved = $this->getTokenizerList('reserved');
 
         $kws = [];
 
-        foreach ([...$tokenizerReservedToplevel, ...$tokenizerReservedNewline] as $v) {
+        foreach ([...$this->getTokenizerList('reservedToplevel'), ...$this->getTokenizerList('reservedNewline')] as $v) {
             foreach (explode(' ', $v) as $kw) {
                 $kws[] = $kw;
             }
         }
 
-        $kwsDiff = array_diff($kws, $tokenizerReserved);
-
-        self::assertSame([], $kwsDiff);
+        self::assertSame([], array_diff($kws, $tokenizerReserved));
     }
 
     #[DoesNotPerformAssertions]