Remove --vsd-intervals as redundant

Author: jezhiggins

src/analyses/variable-sensitivity/variable_sensitivity_object_factory.h

@@ -62,7 +62,6 @@ struct vsd_configt
 
   struct
   {
-    bool intervals;
     bool new_value_set;
   } advanced_sensitivities;
 
@@ -115,8 +114,6 @@ struct vsd_configt
       (config.pointer_abstract_type != VALUE_SET);
     config.context_tracking.data_dependency_context =
       options.get_bool_option("data-dependencies");
-    config.advanced_sensitivities.intervals =
-      options.get_bool_option("interval");
     config.advanced_sensitivities.new_value_set =
       options.get_bool_option("new-value-set");
 
@@ -148,7 +145,6 @@ struct vsd_configt
   {
     vsd_configt config{};
     config.context_tracking.last_write_context = true;
-    config.advanced_sensitivities.intervals = true;
     config.value_abstract_type = INTERVAL;
     config.pointer_abstract_type = POINTER_SENSITIVE;
     config.struct_abstract_type = STRUCT_SENSITIVE;

src/goto-analyzer/goto_analyzer_parse_options.cpp

@@ -374,7 +374,6 @@ void goto_analyzer_parse_optionst::get_command_line_options(optionst &options)
       options.set_option("structs", cmdline.get_value("vsd-structs"));
       options.set_option(
         "data-dependencies", cmdline.isset("vsd-data-dependencies"));
-      options.set_option("interval", cmdline.isset("vsd-intervals"));
     }
     else if(cmdline.isset("dependence-graph-vs"))
     {
@@ -997,7 +996,6 @@ void goto_analyzer_parse_optionst::help()
     " --vsd-arrays                 array entry sensitive analysis - top-bottom|every-element\n"
     " --vsd-pointers               pointer sensitive analysis - top-bottom|constants|value-set\n"
     " --vsd-data-dependencies      track data dependencies\n"
-    " --vsd-intervals              use intervals\n"
     "\n"
     "Storage options:\n"
     // NOLINTNEXTLINE(whitespace/line_length)

src/goto-analyzer/goto_analyzer_parse_options.h

@@ -139,7 +139,7 @@ class optionst;
   "(vsd-structs):" \
   "(vsd-arrays):" \
   "(vsd-pointers):" \
-  "(vsd-data-dependencies)" \
+  "(vsd-data-dependencies)"
 
 #define GOTO_ANALYSER_OPTIONS_STORAGE \
   "(one-domain-per-history)" \