Create symbol name on heap allocation

Author: jezhiggins

regression/goto-analyzer/heap-allocation/test-constant-pointers.desc

@@ -3,5 +3,5 @@ main.c
 --variable-sensitivity --vsd-pointers constants --show
 ^EXIT=0$
 ^SIGNAL=0$
-main::1::i_was_malloced \(\) -> ptr ->\(heap-object\[0\]\)
+main::1::i_was_malloced \(\) -> ptr ->\(allocated-on-heap\[0\]\)
 --

regression/goto-analyzer/heap-allocation/test-value-set-pointers.desc

@@ -3,5 +3,5 @@ main.c
 --variable-sensitivity --vsd-pointers value-set --show
 ^EXIT=0$
 ^SIGNAL=0$
-main::1::i_was_malloced \(\) -> value-set-begin: ptr ->\(heap allocation\) :value-set-end
+main::1::i_was_malloced \(\) -> value-set-begin: ptr ->\(allocated-on-heap\) :value-set-end
 --

src/analyses/variable-sensitivity/abstract_environment.cpp

@@ -88,8 +88,10 @@ abstract_environmentt::eval(const exprt &expr, const namespacet &ns) const
     simplified_id == ID_side_effect &&
     (simplified_expr.get(ID_statement) == ID_allocate))
   {
-    auto heap_symbol = unary_exprt(
-      ID_address_of, exprt(ID_dynamic_object), simplified_expr.type());
+    auto dynamic_object = exprt(ID_dynamic_object);
+    dynamic_object.set(ID_identifier, "allocated-on-heap");
+    auto heap_symbol =
+      unary_exprt(ID_address_of, dynamic_object, simplified_expr.type());
     auto heap_pointer =
       abstract_object_factory(simplified_expr.type(), heap_symbol, ns);
     return heap_pointer;

src/analyses/variable-sensitivity/constant_pointer_abstract_object.cpp

@@ -127,7 +127,7 @@ void constant_pointer_abstract_objectt::output(
       }
       else if(addressee.id() == ID_dynamic_object)
       {
-        out << "heap allocation";
+        out << addressee.get(ID_identifier);
       }
       else if(addressee.id() == ID_index)
       {
@@ -232,7 +232,7 @@ abstract_object_pointert constant_pointer_abstract_objectt::typecast(
     auto heap_array_type = array_typet(new_type.subtype(), nil_exprt());
     auto array_object =
       environment.abstract_object_factory(heap_array_type, ns, true, false);
-    auto heap_symbol = symbol_exprt("heap-object", heap_array_type);
+    auto heap_symbol = symbol_exprt(value.get(ID_identifier), heap_array_type);
     env.assign(heap_symbol, array_object, ns);
     auto heap_address = address_of_exprt(
       index_exprt(heap_symbol, from_integer(0, signed_size_type())));