same_target, offset, offset_from can be private to constant abstract pointer

Author: jezhiggins

src/analyses/variable-sensitivity/abstract_pointer_object.h

@@ -62,10 +62,6 @@ class abstract_pointer_objectt : public abstract_objectt,
     const abstract_environmentt &env,
     const namespacet &ns) const override;
 
-  virtual bool same_target(abstract_object_pointert other) const = 0;
-  virtual exprt offset() const = 0;
-  virtual exprt offset_from(abstract_object_pointert other) const = 0;
-
   /// A helper function to read elements from an array. More precise
   /// abstractions may override this to provide more precise results.
   ///

src/analyses/variable-sensitivity/constant_pointer_abstract_object.h

@@ -143,13 +143,13 @@ class constant_pointer_abstract_objectt : public abstract_pointer_objectt
     const abstract_object_pointert &op1,
     const widen_modet &widen_mode) const override;
 
-  bool same_target(abstract_object_pointert other) const override;
-  exprt offset() const override;
-  exprt offset_from(abstract_object_pointert other) const override;
-
   CLONE
 
 private:
+  bool same_target(abstract_object_pointert other) const;
+  exprt offset() const;
+  exprt offset_from(abstract_object_pointert other) const;
+
   /// Merges two constant pointers. If they are pointing at the same
   /// value, we merge, otherwise we set to top.
   ///

src/analyses/variable-sensitivity/two_value_pointer_abstract_object.cpp

@@ -33,23 +33,6 @@ two_value_pointer_abstract_objectt::two_value_pointer_abstract_objectt(
 {
 }
 
-bool two_value_pointer_abstract_objectt::same_target(
-  abstract_object_pointert other) const
-{
-  return false;
-}
-
-exprt two_value_pointer_abstract_objectt::offset() const
-{
-  return nil_exprt();
-}
-
-exprt two_value_pointer_abstract_objectt::offset_from(
-  abstract_object_pointert other) const
-{
-  return nil_exprt();
-}
-
 abstract_object_pointert two_value_pointer_abstract_objectt::read_dereference(
   const abstract_environmentt &env,
   const namespacet &ns) const

src/analyses/variable-sensitivity/two_value_pointer_abstract_object.h

@@ -34,10 +34,6 @@ class two_value_pointer_abstract_objectt : public abstract_pointer_objectt
     const abstract_environmentt &environment,
     const namespacet &ns);
 
-  bool same_target(abstract_object_pointert other) const override;
-  exprt offset() const override;
-  exprt offset_from(abstract_object_pointert other) const override;
-
   abstract_object_pointert read_dereference(
     const abstract_environmentt &env,
     const namespacet &ns) const override;

src/analyses/variable-sensitivity/value_set_pointer_abstract_object.cpp

@@ -62,23 +62,6 @@ value_set_pointer_abstract_objectt::value_set_pointer_abstract_objectt(
     std::make_shared<constant_pointer_abstract_objectt>(expr, environment, ns));
 }
 
-bool value_set_pointer_abstract_objectt::same_target(
-  abstract_object_pointert other) const
-{
-  return false;
-}
-
-exprt value_set_pointer_abstract_objectt::offset() const
-{
-  return nil_exprt();
-}
-
-exprt value_set_pointer_abstract_objectt::offset_from(
-  abstract_object_pointert other) const
-{
-  return nil_exprt();
-}
-
 abstract_object_pointert value_set_pointer_abstract_objectt::read_dereference(
   const abstract_environmentt &env,
   const namespacet &ns) const

src/analyses/variable-sensitivity/value_set_pointer_abstract_object.h

@@ -59,10 +59,6 @@ class value_set_pointer_abstract_objectt : public abstract_pointer_objectt,
   /// either converted to interval or marked as `top`.
   static const size_t max_value_set_size = 10;
 
-  bool same_target(abstract_object_pointert other) const override;
-  exprt offset() const override;
-  exprt offset_from(abstract_object_pointert other) const override;
-
   abstract_object_pointert read_dereference(
     const abstract_environmentt &env,
     const namespacet &ns) const override;