Simplify struct_abstract_objecctt::write_component

Author: jezhiggins

src/analyses/variable-sensitivity/full_struct_abstract_object.cpp

@@ -104,7 +104,7 @@ abstract_object_pointert full_struct_abstract_objectt::read_component(
   }
 }
 
-sharing_ptrt<struct_abstract_objectt>
+abstract_object_pointert
 full_struct_abstract_objectt::write_component(
   abstract_environmentt &environment,
   const namespacet &ns,
@@ -119,9 +119,8 @@ full_struct_abstract_objectt::write_component(
 
   if(is_bottom())
   {
-    return sharing_ptrt<full_struct_abstract_objectt>(
-      new full_struct_abstract_objectt(
-        member_expr.compound().type(), false, true));
+    return std::make_shared<full_struct_abstract_objectt>(
+        member_expr.compound().type(), false, true);
   }
 
   const auto &result =

src/analyses/variable-sensitivity/full_struct_abstract_object.h

@@ -137,7 +137,7 @@ class full_struct_abstract_objectt : public struct_abstract_objectt
   ///         writing to a specific component. In this case this will
   ///         always be top as we are not tracking the value of this
   ///          struct.
-  sharing_ptrt<struct_abstract_objectt> write_component(
+  abstract_object_pointert write_component(
     abstract_environmentt &environment,
     const namespacet &ns,
     const std::stack<exprt> &stack,

src/analyses/variable-sensitivity/struct_abstract_object.cpp

@@ -68,7 +68,7 @@ abstract_object_pointert struct_abstract_objectt::read_component(
     member_expr.type(), ns, !is_bottom(), is_bottom());
 }
 
-sharing_ptrt<struct_abstract_objectt> struct_abstract_objectt::write_component(
+abstract_object_pointert struct_abstract_objectt::write_component(
   abstract_environmentt &environment,
   const namespacet &ns,
   const std::stack<exprt> &stack,
@@ -78,12 +78,11 @@ sharing_ptrt<struct_abstract_objectt> struct_abstract_objectt::write_component(
 {
   if(is_top() || is_bottom())
   {
-    return std::dynamic_pointer_cast<const struct_abstract_objectt>(clone());
+    return shared_from_this();
   }
   else
   {
-    return sharing_ptrt<struct_abstract_objectt>(
-      new struct_abstract_objectt(type(), true, false));
+    return std::make_shared<struct_abstract_objectt>(type(), true, false);
   }
 }
 

src/analyses/variable-sensitivity/struct_abstract_object.h

@@ -125,7 +125,7 @@ class struct_abstract_objectt : public abstract_objectt
   /// \return The struct_abstract_objectt representing the result of writing
   ///         to a specific component. In this case this will always be top
   ///         as we are not tracking the value of this struct.
-  virtual sharing_ptrt<struct_abstract_objectt> write_component(
+  virtual abstract_object_pointert write_component(
     abstract_environmentt &environment,
     const namespacet &ns,
     const std::stack<exprt> &stack,