goto-cc modes: interpret command-line options to set default verbosity to warning

We already did this for GCC, but we can also do this for other modes
(ARMCC, CodeWarrior, LD, CL, LINK).

Author: tautschnig

src/goto-cc/armcc_mode.cpp

@@ -45,8 +45,10 @@ int armcc_modet::doit()
     has_prefix(base_name, "goto-link");
   #endif
 
+  const auto default_verbosity =
+    cmdline.isset("diag_warning=") ? messaget::M_WARNING : messaget::M_ERROR;
   const auto verbosity = messaget::eval_verbosity(
-    cmdline.get_value("verbosity"), messaget::M_ERROR, message_handler);
+    cmdline.get_value("verbosity"), default_verbosity, message_handler);
 
   messaget log{message_handler};
   log.debug() << "ARM mode" << messaget::eom;

src/goto-cc/cw_mode.cpp

@@ -45,8 +45,10 @@ int cw_modet::doit()
     has_prefix(base_name, "goto-link");
   #endif
 
+  const auto default_verbosity =
+    cmdline.isset("Wall") ? messaget::M_WARNING : messaget::M_ERROR;
   const auto verbosity = messaget::eval_verbosity(
-    cmdline.get_value("verbosity"), messaget::M_ERROR, message_handler);
+    cmdline.get_value("verbosity"), default_verbosity, message_handler);
 
   messaget log{message_handler};
   log.debug() << "CodeWarrior mode" << messaget::eom;

src/goto-cc/ld_mode.cpp

@@ -78,7 +78,10 @@ int ld_modet::doit()
   messaget::eval_verbosity(
     cmdline.get_value("verbosity"), messaget::M_ERROR, gcc_message_handler);
 
-  compilet compiler(cmdline, gcc_message_handler, false);
+  compilet compiler(
+    cmdline,
+    gcc_message_handler,
+    cmdline.isset("fatal-warnings") && !cmdline.isset("no-fatal-warnings"));
 
   // determine actions to be undertaken
   compiler.mode = compilet::LINK_LIBRARY;

src/goto-cc/ms_cl_mode.cpp

@@ -56,8 +56,11 @@ int ms_cl_modet::doit()
     has_prefix(base_name, "goto-link");
   #endif
 
+  const auto default_verbosity = (cmdline.isset("Wall") || cmdline.isset("W4"))
+                                   ? messaget::M_WARNING
+                                   : messaget::M_ERROR;
   const auto verbosity = messaget::eval_verbosity(
-    cmdline.get_value("verbosity"), messaget::M_ERROR, message_handler);
+    cmdline.get_value("verbosity"), default_verbosity, message_handler);
 
   ms_cl_versiont ms_cl_version;
   ms_cl_version.get("cl.exe");

src/goto-cc/ms_link_mode.cpp

@@ -36,7 +36,7 @@ int ms_link_modet::doit()
   messaget::eval_verbosity(
     cmdline.get_value("verbosity"), messaget::M_ERROR, message_handler);
 
-  compilet compiler(cmdline, message_handler, false);
+  compilet compiler(cmdline, message_handler, cmdline.isset("WX"));
 
   // determine actions to be undertaken
   compiler.mode = compilet::LINK_LIBRARY;