Ensure comparisons of integers are of the same sign.

A lot of the comparisons we did previously seemed unsound -
they compared integers of different signs. Catch didn't
like this much, forcing us to change sign comparisons to
be explicit.

Author: NlightNFotis

unit/util/dense_integer_map.cpp

@@ -124,7 +124,7 @@ TEST_CASE("iterators", "[core][util][dense_integer_map]")
   REQUIRE(map.begin() != std::next(map.begin()));
   REQUIRE(map.begin() == map.begin());
   REQUIRE(map.size() == 2);
-  REQUIRE(std::distance(map.begin(), map.end()) == map.size());
+  REQUIRE(std::distance(map.begin(), map.end()) == (ptrdiff_t)map.size());
 
   {
     const auto &const_map = map;

unit/util/sharing_map.cpp

@@ -257,7 +257,7 @@ void sharing_map_internals_test()
       delta_view.clear();
       sm2.get_delta_view(sm1, delta_view, false);
       REQUIRE(delta_view.size() == 1);
-      REQUIRE(delta_view[0].k == (1 << (2 * chunk)));
+      REQUIRE(delta_view[0].k == (unsigned)(1 << (2 * chunk)));
     }
   }
 }
@@ -675,12 +675,12 @@ TEST_CASE("Sharing map views and iteration", "[core][util]")
         REQUIRE(delta_view[0].m == "a");
         REQUIRE(delta_view[0].get_other_map_value() == "c");
 
-        REQUIRE(delta_view[1].k == 1 << (2 * chunk));
+        REQUIRE(delta_view[1].k == (unsigned)1 << (2 * chunk));
         REQUIRE(delta_view[1].m == "b");
       }
       else
       {
-        REQUIRE(delta_view[0].k == 1 << (2 * chunk));
+        REQUIRE(delta_view[0].k == (unsigned)1 << (2 * chunk));
         REQUIRE(delta_view[0].m == "b");
 
         REQUIRE(delta_view[1].k == 0);

unit/util/small_map.cpp

@@ -46,7 +46,7 @@ void small_map_test()
 
   SECTION("Iterator")
   {
-    small_mapt<int> m;
+    small_mapt<unsigned int> m;
 
     m[0] = 0;
     m[3] = 3;