Skip to content

Commit 168bf86

Browse files
jezhigginsjezhiggins
committed
Pass all immutable abstract_objectt::write parameters as const-ref
stack and value were being passed as const values.
1 parent 462e879 commit 168bf86

30 files changed

+86
-93
lines changed

‎src/analyses/variable-sensitivity/abstract_object.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,9 @@ abstract_object_pointert abstract_objectt::read(
147147
abstract_object_pointert abstract_objectt::write(
148148
abstract_environmentt &environment,
149149
const namespacet &ns,
150-
const std::stack<exprt> stack,
150+
const std::stack<exprt> &stack,
151151
const exprt &specifier,
152-
const abstract_object_pointert value,
152+
const abstract_object_pointert &value,
153153
bool merging_write) const
154154
{
155155
return environment.abstract_object_factory(type(), ns, true);

‎src/analyses/variable-sensitivity/abstract_object.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,9 @@ class abstract_objectt : public std::enable_shared_from_this<abstract_objectt>
213213
virtual abstract_object_pointert write(
214214
abstract_environmentt &environment,
215215
const namespacet &ns,
216-
const std::stack<exprt> stack,
216+
const std::stack<exprt> &stack,
217217
const exprt &specifier,
218-
const abstract_object_pointert value,
218+
const abstract_object_pointert &value,
219219
bool merging_write) const;
220220

221221
/// Print the value of the abstract object

‎src/analyses/variable-sensitivity/array_abstract_object.cpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ abstract_object_pointert array_abstract_objectt::read(
4646
abstract_object_pointert array_abstract_objectt::write(
4747
abstract_environmentt &environment,
4848
const namespacet &ns,
49-
const std::stack<exprt> stack,
49+
const std::stack<exprt> &stack,
5050
const exprt &specifier,
51-
const abstract_object_pointert value,
51+
const abstract_object_pointert &value,
5252
bool merging_write) const
5353
{
5454
return this->write_index(
@@ -71,9 +71,9 @@ abstract_object_pointert array_abstract_objectt::read_index(
7171
abstract_object_pointert array_abstract_objectt::write_index(
7272
abstract_environmentt &environment,
7373
const namespacet &ns,
74-
const std::stack<exprt> stack,
74+
const std::stack<exprt> &stack,
7575
const index_exprt &index_expr,
76-
const abstract_object_pointert value,
76+
const abstract_object_pointert &value,
7777
bool merging_write) const
7878
{
7979
// TODO(tkiley): Should this in fact havoc since we can't verify

‎src/analyses/variable-sensitivity/array_abstract_object.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ class array_abstract_objectt : public abstract_objectt
7878
abstract_object_pointert write(
7979
abstract_environmentt &environment,
8080
const namespacet &ns,
81-
const std::stack<exprt> stack,
81+
const std::stack<exprt> &stack,
8282
const exprt &specifier,
83-
const abstract_object_pointert value,
83+
const abstract_object_pointert &value,
8484
bool merging_write) const override;
8585

8686
void get_statistics(
@@ -123,9 +123,9 @@ class array_abstract_objectt : public abstract_objectt
123123
virtual abstract_object_pointert write_index(
124124
abstract_environmentt &environment,
125125
const namespacet &ns,
126-
const std::stack<exprt> stack,
126+
const std::stack<exprt> &stack,
127127
const index_exprt &index_expr,
128-
const abstract_object_pointert value,
128+
const abstract_object_pointert &value,
129129
bool merging_write) const;
130130
};
131131

‎src/analyses/variable-sensitivity/constant_array_abstract_object.cpp‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,13 +189,12 @@ abstract_object_pointert constant_array_abstract_objectt::read_index(
189189
}
190190
}
191191

192-
abstract_object_pointert
193-
constant_array_abstract_objectt::write_index(
192+
abstract_object_pointert constant_array_abstract_objectt::write_index(
194193
abstract_environmentt &environment,
195194
const namespacet &ns,
196-
const std::stack<exprt> stack,
195+
const std::stack<exprt> &stack,
197196
const index_exprt &index_expr,
198-
const abstract_object_pointert value,
197+
const abstract_object_pointert &value,
199198
bool merging_write) const
200199
{
201200
if(is_bottom())

‎src/analyses/variable-sensitivity/constant_array_abstract_object.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@ class constant_array_abstract_objectt : public array_abstract_objectt
115115
abstract_object_pointert write_index(
116116
abstract_environmentt &environment,
117117
const namespacet &ns,
118-
const std::stack<exprt> stack,
118+
const std::stack<exprt> &stack,
119119
const index_exprt &index_expr,
120-
const abstract_object_pointert value,
120+
const abstract_object_pointert &value,
121121
bool merging_write) const override;
122122

123123
/// Tries to do an array/array merge if merging with a constant array

‎src/analyses/variable-sensitivity/constant_pointer_abstract_object.cpp‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,12 +169,11 @@ abstract_object_pointert constant_pointer_abstract_objectt::read_dereference(
169169
}
170170
}
171171

172-
abstract_object_pointert
173-
constant_pointer_abstract_objectt::write_dereference(
172+
abstract_object_pointert constant_pointer_abstract_objectt::write_dereference(
174173
abstract_environmentt &environment,
175174
const namespacet &ns,
176-
const std::stack<exprt> stack,
177-
const abstract_object_pointert new_value,
175+
const std::stack<exprt> &stack,
176+
const abstract_object_pointert &new_value,
178177
bool merging_write) const
179178
{
180179
if(is_top() || is_bottom() || value_stack.is_top_value())

‎src/analyses/variable-sensitivity/constant_pointer_abstract_object.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@ class constant_pointer_abstract_objectt : public pointer_abstract_objectt
102102
abstract_object_pointert write_dereference(
103103
abstract_environmentt &environment,
104104
const namespacet &ns,
105-
const std::stack<exprt> stack,
106-
const abstract_object_pointert value,
105+
const std::stack<exprt> &stack,
106+
const abstract_object_pointert &value,
107107
bool merging_write) const override;
108108

109109
void get_statistics(

‎src/analyses/variable-sensitivity/context_abstract_object.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ abstract_object_pointert context_abstract_objectt::read(
7171
abstract_object_pointert context_abstract_objectt::write(
7272
abstract_environmentt &environment,
7373
const namespacet &ns,
74-
const std::stack<exprt> stack,
74+
const std::stack<exprt> &stack,
7575
const exprt &specifier,
76-
const abstract_object_pointert value,
76+
const abstract_object_pointert &value,
7777
bool merging_write) const
7878
{
7979
abstract_object_pointert updated_child = child_abstract_object->write(

‎src/analyses/variable-sensitivity/context_abstract_object.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@ class context_abstract_objectt : public abstract_objectt
115115
abstract_object_pointert write(
116116
abstract_environmentt &environment,
117117
const namespacet &ns,
118-
const std::stack<exprt> stack,
118+
const std::stack<exprt> &stack,
119119
const exprt &specifier,
120-
const abstract_object_pointert value,
120+
const abstract_object_pointert &value,
121121
bool merging_write) const override;
122122

123123
bool has_been_modified(const abstract_object_pointert before) const override;

0 commit comments

Comments
 (0)