Introduce reference to avoid unneeded copy.

Fotis Koutoulakis · Fotis Koutoulakis · commit 05599727a810 · 2020-10-14T17:40:29.000+01:00
Previously this broke the build on macOS,
because the compiler was complaining about
creating a copy of a const std::pair - which
registered as an error (because of -Werror).
diff --git a/jbmc/src/java_bytecode/lambda_synthesis.cpp b/jbmc/src/java_bytecode/lambda_synthesis.cpp
@@ -156,7 +156,7 @@ get_interface_methods(const irep_idt &interface_id, const namespacet &ns)
   {
     const methods_by_name_and_descriptort base_methods =
       get_interface_methods(base.type().get_identifier(), ns);
-    for(const auto base_method : base_methods)
+    for(const auto &base_method : base_methods)
     {
       if(base_method.second)
       {

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ get_interface_methods(const irep_idt &interface_id, const namespacet &ns)`
`156`	`156`	`{`
`157`	`157`	`const methods_by_name_and_descriptort base_methods =`
`158`	`158`	`get_interface_methods(base.type().get_identifier(), ns);`
`159`		`- for(const auto base_method : base_methods)`
	`159`	`+ for(const auto &base_method : base_methods)`
`160`	`160`	`{`
`161`	`161`	`if(base_method.second)`
`162`	`162`	`{`