Skip to content

Commit 9163206

Browse files
committed
Disable Js\Server::__get(), since we don't need it right now and it's broken.
We can trigger segfaults and ZZZZZ reads when using __get from JavaScript, so there's something wrong here. We don't actually need this right now (__set is enough), so just disable it. We'll fix or replace it later.
1 parent 9c961c5 commit 9163206

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/node_php_jsserver_class.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ ZEND_END_ARG_INFO()
9090

9191
PHP_METHOD(JsServer, __get) {
9292
TRACE(">");
93+
#if 0 // XXX disabled, since it seems to be corrupting memory.
9394
zval *member;
9495
PARSE_PARAMS(__get, "z/", &member);
9596
convert_to_string(member);
@@ -104,6 +105,9 @@ PHP_METHOD(JsServer, __get) {
104105
} else {
105106
*return_value_ptr = *retval;
106107
}
108+
#else
109+
ZVAL_BOOL(return_value, true);
110+
#endif
107111
TRACE("<");
108112
}
109113

0 commit comments

Comments
 (0)