feat(AssetFieldType): implement dynamic Field-driven image_optim config

Author: toastercup

app/uploaders/asset_uploader.rb

@@ -31,9 +31,10 @@ class AssetUploader < Shrine
     versions = { original: io.download }
 
     if image?(io)
+      image_optim = image_optim_for(context[:config][:metadata][:image_optim_config])
       versions.merge!(context[:config][:metadata][:versions].transform_values do |version|
         processed_version = send("#{version[:process][:method]}!", io.download, *version[:process][:config].values)
-        optimize_image!(processed_version)
+        optimize_image!(processed_version, image_optim) # TODO: per-version image_optim_config
       end)
     end
 
@@ -54,9 +55,26 @@ def image?(io)
     MimeMagic.new(io.data['metadata']['mime_type']).mediatype == 'image'
   end
 
-  def optimize_image!(image)
-    image_optim = ImageOptim.new(pngout: false, svgo: false, allow_lossy: true) # TODO: implement per-Field/version image_optim configuration
-    pathname = image_optim.optimize_image!(image)
+  private
+
+  def optimize_image!(image, image_optim)
+    pathname = image_optim.optimize_image!(image) # TODO: move to ActiveJob
     pathname ? pathname.open : image
   end
+
+  def image_optim_for(image_optim_config)
+    ImageOptim.new(process_image_optim_config(image_optim_config))
+  end
+
+  def process_image_optim_config(image_optim_config)
+    processed_image_optim_config = image_optim_config.merge(pngout: false, svgo: false, verbose: true, skip_missing_workers: false)
+    processed_image_optim_config.extend(Hashie::Extensions::DeepLocate)
+    quality_range_hashes = processed_image_optim_config.deep_locate -> (key, value, object) { key == :quality_range }
+    quality_range_hashes.each do |quality_range_hash|
+      quality_range_hash[:quality] = quality_range_hash[:quality_range][:begin]..quality_range_hash[:quality_range][:end]
+      quality_range_hash.delete(:quality_range)
+    end
+
+    processed_image_optim_config
+  end
 end

lib/tasks/cortex/core/media.rake

@@ -32,7 +32,7 @@ namespace :cortex do
                              naming_data: {
                                title: fieldTitle.id
                              },
-                             versions: {
+                             versions: { # Move to YAML
                                large: { process: { method: 'resize_to_limit', config: { width: '1800', height: '1800' } } },
                                medium: { process: { method: 'resize_to_limit', config: { width: '800', height: '800' } } },
                                default: { process: { method: 'resize_to_limit', config: { width: '300', height: '300' } } },
@@ -42,7 +42,7 @@ namespace :cortex do
                              },
                              keep_files: [:destroyed, :replaced],
                              path: 'media/<%= attachment %>/<%= original_name %>-<%= style %>-<%= generated_hex %>.<%= extension %>',
-                             storage: {
+                             storage: { # Move to YAML
                                type: 's3',
                                host_alias: ENV['HOST_ALIAS'],
                                config: {
@@ -55,6 +55,33 @@ namespace :cortex do
                                    cache_control: 'public, max-age=315576000'
                                  }
                                }
+                             },
+                             image_optim_config: {  # Move to YAML
+                               allow_lossy: true,
+                               jpegoptim: {
+                                 allow_lossy: true,
+                                 strip: 'all',
+                                 max_quality: 60
+                               },
+                               pngquant: {
+                                 allow_lossy: true,
+                                 quality_range: {
+                                   begin: 33,
+                                   end: 50
+                                 },
+                                 speed: 3
+                               },
+                               gifsicle: {
+                                 interlace: true
+                               },
+                               advpng: false,
+                               jhead: false,
+                               jpegrecompress: false,
+                               jpegtran: false,
+                               optipng: false,
+                               pngcrush: false,
+                               pngout: false,
+                               svgo: false
                              }
                            })
         media.fields.new(name: 'Description', field_type: 'text_field_type', validations: {presence: true})