Don't leave NewTopic partially-initialized on error #2151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `NewTopic` was initialized with a non-dict `config`, then the constructor raised an exception but left the object in a partially-initialized state with `replica_assignment` and `config` elements that hadn't had their reference counts increased, leading to mysterious segfaults in the test suite. Be more careful to only set these elements once we're ready to do so. Fixes: confluentinc#2146
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Contributor
|
/sem-approve |
MSeal
approved these changes
Dec 5, 2025
Contributor
MSeal
left a comment
MSeal
left a comment
There was a problem hiding this comment.
Thanks for the fix. I've validated the change locally and kicked off the test suite validation. Once it passes I'll merge the change. There's a release being prepped for mid December that will include this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
NewTopicwas initialized with a non-dictconfig, then the constructor raised an exception but left the object in a partially-initialized state withreplica_assignmentandconfigelements that hadn't had their reference counts increased, leading to mysterious segfaults in the test suite. Be more careful to only set these elements once we're ready to do so.Fixes: #2146