Merge pull request #41 from cakper/fix-regex-matcher-edge-case

Add casting to bool for expression regex matches

Author: Norbert Orzechowicz

src/Coduo/PHPMatcher/Matcher/ExpressionMatcher.php

@@ -22,7 +22,7 @@ public function match($value, $pattern)
             $this->error = sprintf("\"%s\" expression fails for value \"%s\".", $pattern, new String($value));
         }
 
-        return $expressionResult;
+        return (bool) $expressionResult;
     }
 
     /**

tests/Coduo/PHPMatcher/Matcher/ExpressionMatcherTest.php

@@ -51,6 +51,24 @@ public function test_negative_match_description($value, $pattern, $error)
         $this->assertEquals($error, $matcher->getError());
     }
 
+    /**
+     * @dataProvider positiveRegexMatchData
+     */
+    public function test_positive_regex_matches($value, $pattern)
+    {
+        $matcher = new ExpressionMatcher();
+        $this->assertTrue($matcher->match($value, $pattern));
+    }
+
+    /**
+     * @dataProvider negativeRegexMatchData
+     */
+    public function test_negative_regex_matches($value, $pattern)
+    {
+        $matcher = new ExpressionMatcher();
+        $this->assertFalse($matcher->match($value, $pattern));
+    }
+
     public static function positiveCanMatchData()
     {
         return array(
@@ -98,4 +116,20 @@ public static function negativeMatchDescription()
             ),
         );
     }
+
+    public static function positiveRegexMatchData()
+    {
+        return array(
+            array('Cakper', 'expr(value matches "/Cakper/")'),
+            array('Cakper', 'expr(not(value matches "/Yaboomaster/"))'),
+        );
+    }
+
+    public static function negativeRegexMatchData()
+    {
+        return array(
+            array('Cakper', 'expr(not(value matches "/Cakper/"))'),
+            array('Cakper', 'expr(value matches "/Yaboomaster/")'),
+        );
+    }
 }