SAAS-5634 As a user I will see a warning in cli when I validate pipeline (#407)

* SAAS-5634 As a user I will see a warning in cli when I validate pipeline

* SAAS-5634 As a user I will see a warning in cli when I validate pipeline

* SAAS-5634 As a user I will see a warning in cli when I validate pipeline

Author: vadim-kharin-codefresh

lib/interface/cli/commands/root/validate.cmd.js

@@ -8,6 +8,11 @@ const { pathExists, watchFile } = require('../../helpers/general');
 const VALID_MESSAGE = Style.green('Yaml is valid!');
 
 function _getResultMessage(result = {}) {
+    if (result.warning) {
+        return result.valid
+            ? `${Style.yellow(result.warning)}`
+            : `${Style.red(result.message)}\n${Style.yellow(result.warning)}\n`;
+    }
     return result.valid
         ? VALID_MESSAGE
         : `${Style.red(result.message)}\n`;
@@ -57,15 +62,13 @@ const validateCmd = new Command({
             return console.log('No filename provided!');
         }
 
-        const checkPromises = filenames.map((filename) => {
-            return pathExists(filename)
-                .then((exists) => {
-                    if (!exists) {
-                        console.log(`File does not exist: ${filename}`);
-                    }
-                    return exists;
-                });
-        });
+        const checkPromises = filenames.map(filename => pathExists(filename)
+            .then((exists) => {
+                if (!exists) {
+                    console.log(`File does not exist: ${filename}`);
+                }
+                return exists;
+            }));
         const allExist = (await Promise.all(checkPromises)).reduce((a, b) => a && b);
 
         if (!allExist) {

lib/interface/cli/helpers/validation.js

@@ -1,20 +1,28 @@
 const _ = require('lodash');
 const yaml = require('js-yaml');
+const path = require('path');
 const { readFile, ignoreHttpError } = require('./general');
 const { sdk } = require('../../../logic');
 const CFError = require('cf-errors');
 
 
 function _buildFinalMessage(baseMessage, validationResult) {
-    if (_.isArray(validationResult.details)) {
-        const errors = validationResult.details
+    if (_.isArray(validationResult)) {
+        const errors = validationResult
             .map(({ message }) => `  - ${message}`)
             .join('\n');
         return `${baseMessage}:\n${errors}`;
     }
     return `${baseMessage}!`;
 }
 
+function _getPipelineName(filename) {
+    if (filename) {
+        return path.basename(filename, path.extname(filename));
+    }
+    return filename;
+}
+
 async function validatePipelineSpec(data) {
     const steps = _.get(data, 'spec.steps');
     const stages = _.get(data, 'spec.stages');
@@ -31,20 +39,29 @@ async function validatePipelineSpec(data) {
     const validatedYaml = yaml.safeDump(yamlObj);
     const result = await sdk.pipelines.validateYaml({ yaml: validatedYaml });
     let message;
+    let warning;
     if (!result.valid) {
-        message = _buildFinalMessage('Provided spec is not valid', result);
+        message = _buildFinalMessage('Provided spec is not valid', result.details);
     }
-    return { valid: !!result.valid, message };
+    if (!_.isEmpty(result.warningDetails)) {
+        warning = _buildFinalMessage('Yaml has warnings', result.warningDetails);
+    }
+    return { valid: !!result.valid, message, warning };
 }
 
 async function validatePipelineYaml(filename, fileContent) {
     const yamlContent = fileContent || await readFile(filename, 'UTF-8');
-    const result = await sdk.pipelines.validateYaml({ yaml: yamlContent });
+    const name = _getPipelineName(filename);
+    const result = await sdk.pipelines.validateYaml({ yaml: yamlContent, name });
     let message;
+    let warning;
     if (!result.valid) {
-        message = _buildFinalMessage('Yaml not valid', result);
+        message = _buildFinalMessage('Yaml not valid', result.details);
+    }
+    if (!_.isEmpty(result.warningDetails)) {
+        warning = _buildFinalMessage('Yaml has warnings', result.warningDetails);
     }
-    return { valid: !!result.valid, message };
+    return { valid: !!result.valid, message, warning };
 }
 
 async function checkOrProjectExists(projectName) {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.43.0",
+  "version": "0.43.1",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,