[STG-1045] Add logging at all 4 levels: agent.execute, agent.act/observe/extract, CLICK/HOVER/SCROLL, and CDP #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
pirate
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
pirate
force-pushed
the
flow-logs
branch
2 times, most recently
from
69404e7 to
a58f549
Compare
- Add SessionFileLogger class that writes to session-specific directories
- Read BROWSERBASE_CONFIG_DIR from env (defaults to ./.browserbase)
- Create session directory structure: {configDir}/sessions/{sessionId}/
- Create convenience symlink: {configDir}/sessions/latest
- Write to 5 separate log files:
- session.json (sanitized V3Options with secrets masked)
- agent_events.log (TASK level - agent.execute)
- stagehand_events.log (STEP level - act/observe/extract)
- understudy_events.log (ACTION level - CLICK/HOVER/etc)
- cdp_events.log (CDP MSG level)
- All filesystem operations are async, non-blocking, and fail silently
- Logs still also written to stdout via v3Logger for backwards compatibility
- Add .browserbase/ to .gitignore
- Update flowLoggingJourney example to show session log directory
Co-authored-by: Nick Sweeting <pirate@users.noreply.github.com>
…nt ids, cleanup code
This comment was marked as resolved.
This comment was marked as resolved.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
miguelg719
reviewed
Dec 8, 2025
miguelg719
reviewed
Dec 8, 2025
miguelg719
reviewed
Dec 8, 2025
| const llmRequestId = uuidv7(); | ||
| SessionFileLogger.logLlmRequest({ | ||
| requestId: llmRequestId, | ||
| model: this.modelName, |
Collaborator
There was a problem hiding this comment.
note for the future, we might want to keep track of other params (non-sensitive) in model based on the ModelConfiguration type
Member
Author
There was a problem hiding this comment.
note for compactness we can also store the default model config in sessions/{id}/session.json dir, and then only add extra to the individual loglines if they are different from the session-wide defaults.
miguelg719
reviewed
Dec 8, 2025
Comment on lines
+33
to
+35
| // ============================================================================= | ||
| // Types | ||
| // ============================================================================= |
Collaborator
There was a problem hiding this comment.
These are okay because this file is a stepping stone so keeping them here to accelerate implementation, will move to types dir once stable
miguelg719
reviewed
Dec 8, 2025
Comment on lines
+119
to
+121
| // ============================================================================= | ||
| // Formatting Utilities (used by pretty streams) | ||
| // ============================================================================= |
Collaborator
There was a problem hiding this comment.
Same with these, will eventually move to utils
miguelg719
reviewed
Dec 8, 2025
miguelg719
approved these changes
Dec 8, 2025
Co-authored-by: Miguel <36487034+miguelg719@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
Clarify where the execution flow goes when stagehand runs by showing more detailed logs.
what changed
Adds a log line printed at the beginning and end of each layer's execution:
Log lines are written to
./.browserbase/sessions/{sessionId}/{agent,stagehand,understudy,cdp}.logat runtime, and can be followed in a single unified screen by doing:tail -f ./.browserbase/sessions/latest/*.logtest plan
Test by running:
flowLoggingJourney.ts:EXPECTED OUTPUT: