-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
UI per text section picking #22047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ickshonpe
wants to merge
14
commits into
bevyengine:main
Choose a base branch
from
ickshonpe:text_section_picking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UI per text section picking #22047
+86
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inter is over a text node.
…it a second time. * Add the entity of the text section hit to `hit_nodes`. * When picked node is a text node and `require_markers` is enabled, check if the hit section entity is picked.
…The observers turn the section's color to white when the pointer hovers them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Picking
Pointing at and selecting objects of all sorts
A-Text
Rendering and layout for characters
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Feature
A new feature, making something new possible
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
M-Release-Note
Work that should be called out in the blog due to impact
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow picking text per section.
Fixes #17477
Solution
NodeQuery.pick_ui_text. Finds if a text section is hovered and returns its id.hit_nodeswhen hovered.hit_nodes, instead of querying for it a second time.require_markersis enabled, check if the hit section entity has aPickablecomponent, instead of the text node.This design might need to be changed later to allow for text selection and copying. But there doesn't seem any need to overcomplicate things for now by considering it.
Testing
I added observers to the
TextBackgroundColorsexample's text entities. The observers turn a text section's text color to white when the pointer hovers them.