Font weight support #22038
Open
Font weight support #22038
+320
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a `weight: Weight` field to `TextFont`.
`clamp` is called on `Weight` in the `From` impl for `cosmic_text::Weight`
ickshonpe
added
A-Text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add font weight support.
Solution
New
FontWeightstruct that newtypes au16.New
font: FontWeightfield onTextFont.The weight attribute for the cosmic text buffer is set in
TextPipelineduring text updates.I added stretch and slant as well, but split them off from this PR. Swash only has limited variable-font support and there's no way to demonstrate that they work without other changes.
Testing
Added a basic example:
cargo run --example font_weightsThe example uses the Noto Sans font, this should probably be removed before merging as it's quite large.
Showcase