Skip to content

Improves SubsonicUpdate error messages when server is unavailable #5635 #6197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasling920 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Improves SubsonicUpdate error messages when server is unavailable #5635 #6197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
30cd320
Fix Issue #5635: improve SubsonicUpdate error messages when server is…
jaslingm Dec 1, 2025
6e08aa0
Add changelog entry for #5635 subsonicupdate error messages
jaslingm Dec 1, 2025
a81456a
Apply formatting and fix lint issues
jaslingm Dec 4, 2025
51be7be
Simplifies subsonicupdate JSON handling and updated changelog
jaslingm Dec 5, 2025
5f1975c
Simplify SubsonicUpdate JSON handling and fix changelog formatting
jaslingm Dec 5, 2025
948cdac
Fix subsonicupdate entry in changelog
jaslingm Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions beetsplug/subsonicupdate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,21 +138,24 @@ def start_scan(self):
params=payload,
timeout=10,
)
json = response.json()

if (
response.status_code == 200
and json["subsonic-response"]["status"] == "ok"
):
count = json["subsonic-response"]["scanStatus"]["count"]
self._log.info("Updating Subsonic; scanning {} tracks", count)
elif (
response.status_code == 200
and json["subsonic-response"]["status"] == "failed"
):
response.raise_for_status()
try:
json = response.json()
except ValueError:
self._log.error(
"Error: {[subsonic-response][error][message]}", json
"Invalid JSON from Subsonic: {}", response.text[:200]
)
return
if not (resp := json.get("subsonic-response")):
self._log.error("Missing 'subsonic-response' field: {}", json)
return
status = resp.get("status")
Copy link
Contributor

@semohr semohr Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to be defensive here? The same applies to resp.get("scanStatus", {}).get("count", 0) below.

if status == "ok":
count = resp.get("scanStatus", {}).get("count", 0)
self._log.info("Updating Subsonic; scanning {} tracks", count)
elif status == "failed":
Copy link
Contributor

@semohr semohr Dec 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we raise for status, status == "failed" can never be reached. Atleast I think this is the case or does subsonic not use HTTPErrorCodes?

msg = resp.get("error", {}).get("message", "Unknown error")
self._log.error("Error: {}", msg)
else:
self._log.error("Error: {}", json)
except Exception as error:
Expand Down
3 changes: 3 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ New features:

Bug fixes:

- :doc:`plugins/subsonicupdate`: Improve error messages when the Subsonic server
is unavailable or returns invalid JSON. Previously, failures were cryptic
(for instance, "Expecting value: line 1 column 1 (char 0)"). :bug:`5635`
- :doc:`plugins/inline`: Fix recursion error when an inline field definition
shadows a built-in item field (e.g., redefining ``track_no``). Inline
expressions now skip self-references during evaluation to avoid infinite
Expand Down