From 67dab995cce3ccb830715b0cbb90d80155bc264d Mon Sep 17 00:00:00 2001 From: hkobew Date: Tue, 21 Jan 2025 16:12:37 -0500 Subject: [PATCH 1/2] port definition --- telemetry/definitions/commonDefinitions.json | 40 ++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index e082e8fa8..ccdb6303a 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -209,6 +209,11 @@ ], "description": "User inputted check type to denote which custom check to run." }, + { + "name": "childProcess", + "type": "string", + "description": "A string representation of a ChildProcess" + }, { "name": "cloudWatchLogsPresentation", "type": "string", @@ -1453,6 +1458,11 @@ "type": "int", "description": "Number of generations before the user accepted or rejected" }, + { + "name": "numChildProcesses", + "type": "int", + "description": "number of child processes actively running" + }, { "name": "oldVersion", "type": "string", @@ -1680,6 +1690,12 @@ "CodeOnly" ] }, + { + "name": "systemResource", + "type": "string", + "allowedValues": ["cpu", "memory"], + "description": "The system resource being measured" + }, { "name": "templateName", "type": "string", @@ -5742,6 +5758,20 @@ } ] }, + { + "name": "ide_childProcessWarning", + "description": "Child Process warning due to high system usage", + "metadata": [ + { + "type": "systemResource", + "required": true + }, + { + "type": "childProcess", + "required": true + } + ] + }, { "name": "ide_editCodeFile", "description": "User opened a code file with the given file extension. Client should DEDUPLICATE this metric (ideally hourly/daily). AWS-specific files should (also) emit `file_editAwsFile`.", @@ -5753,6 +5783,16 @@ } ] }, + { + "name": "ide_showExtStats", + "description": "Emitted when user invokes show extensions stats command", + "metadata": [ + { + "type": "numChildProcesses", + "required": true + } + ] + }, { "name": "lambda_configure", "description": "Called when opening the local configuration of a Lambda to edit", From 46033b77867d5883d075fa970e55f44df2d0caed Mon Sep 17 00:00:00 2001 From: hkobew Date: Tue, 21 Jan 2025 16:17:32 -0500 Subject: [PATCH 2/2] fix sorting issues --- telemetry/definitions/commonDefinitions.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index ccdb6303a..da8f636c4 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -5763,13 +5763,13 @@ "description": "Child Process warning due to high system usage", "metadata": [ { - "type": "systemResource", + "type": "childProcess", "required": true - }, + }, { - "type": "childProcess", + "type": "systemResource", "required": true - } + } ] }, {