Applying suggestions by A. Catozzi upon internal review

- removed unnecessary call to _mqttReconnect(...) in ArduinoIoTCloud
- removed unncessary begin() into case IOT_STATUS_IDLE in ArduinoIoTCloud
- removed unnecessary calls to update() in CloudSerial
- fixed if statement in ConnectionManager

Author: ubidefeo

src/ArduinoIoTCloud.cpp

@@ -117,7 +117,6 @@ int ArduinoIoTCloudClass::begin(Client& net, String brokerAddress)
 
 
   // TODO: Find a better way to allow callback into object method
-
   // Begin function for the MQTTClient
   mqttClientBegin();
 
@@ -212,13 +211,6 @@ void ArduinoIoTCloudClass::update(int const reconnectionMaxRetries, int const re
   if(iotStatus != IOT_STATUS_CLOUD_CONNECTED){
     return;
   }
-  // Method's argument controls
-  int const maxRetries = (reconnectionMaxRetries > 0) ? reconnectionMaxRetries : MAX_RETRIES;
-  int const timeout    = (reconnectionTimeoutMs  > 0) ? reconnectionTimeoutMs  : RECONNECTION_TIMEOUT;
-
-  // If the reconnect() culd not establish the connection, return the control to the user sketch
-  if (!mqttReconnect(maxRetries, timeout))
-    return;
 
   // MTTQClient connected!, poll() used to retrieve data from MQTT broker
   _mqttClient->poll();
@@ -323,20 +315,9 @@ void ArduinoIoTCloudClass::connectionCheck() {
   switch (iotStatus) {
     case IOT_STATUS_IDLE:
     {
-      int connectionAttempt;
-      if(connection == NULL){
-        connectionAttempt = begin(*_net, _brokerAddress);
-      }else{
-        connectionAttempt = begin(connection, _brokerAddress);
-      }
-      if(!connectionAttempt){
-        debugMessage("Error Starting Arduino Cloud\nTrying again in a few seconds", 0);
-        setIoTConnectionState(IOT_STATUS_CLOUD_ERROR);
-        return;
-      }
       setIoTConnectionState(IOT_STATUS_CLOUD_CONNECTING);
       break;
-    } 
+    }
 
     case IOT_STATUS_CLOUD_ERROR:
       debugMessage("Cloud Error. Retrying...", 0);

src/CloudSerial.cpp

@@ -38,35 +38,30 @@ void CloudSerialClass::end()
 
 int CloudSerialClass::available()
 {
-  ArduinoCloud.update();
 
   return _rxBuffer.available();
 }
 
 int CloudSerialClass::availableForWrite()
 {
-  ArduinoCloud.update();
 
   return _txBuffer.availableForStore();
 }
 
 int CloudSerialClass::peek()
 {
-  ArduinoCloud.update();
 
   return _rxBuffer.peek();
 }
 
 int CloudSerialClass::read()
 {
-  ArduinoCloud.update();
 
   return _rxBuffer.read_char();
 }
 
 void CloudSerialClass::flush()
 {
-  ArduinoCloud.update();
 
   byte out[CLOUD_SERIAL_TX_BUFFER_SIZE];
   int length = 0;
@@ -91,7 +86,6 @@ size_t CloudSerialClass::write(const uint8_t data)
 
 CloudSerialClass::operator bool()
 {
-  ArduinoCloud.update();
 
   return ArduinoCloud.connected();
 }

src/ConnectionManager.h

@@ -84,14 +84,14 @@ inline void debugMessage(char *_msg, uint8_t _debugLevel, bool _timestamp = true
   if (_debugLevel <= debugMessageLevel) {
     char prepend[20];
     sprintf(prepend, "\n[ %d ] ", millis());
-    if(_timestamp)
+    if(_timestamp){
       Serial.print(prepend);
+    }
     if(_newline){
       Serial.println(_msg);
     }else{
       Serial.print(_msg);
     }
-    
   }
 }