Skip to content

fix: Align Request.state transitions with Request lifecycle #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Mantisus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Align Request.state transitions with Request lifecycle #1601

Mantisus wants to merge 1 commit into from
+127 −14

Conversation

@Mantisus
Copy link
Collaborator

@Mantisus Mantisus commented Dec 5, 2025 •
edited
Loading

Description

  • Set the appropriate statuses for Request.state at the appropriate stages.
  • Set the correct final status for Request.

Testing

  • Add new tests

@Mantisus Mantisus requested review from janbuchar and vdusek December 5, 2025 15:36
@Mantisus Mantisus self-assigned this Dec 5, 2025
vdusek
vdusek approved these changes Dec 6, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

janbuchar
janbuchar approved these changes Dec 6, 2025
View reviewed changes
Copy link
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janbuchar janbuchar janbuchar approved these changes

@vdusek vdusek vdusek approved these changes

Assignees

@Mantisus Mantisus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mantisus @janbuchar @vdusek