From a09fa5d01a82617d131838bc2256e8b30da3f820 Mon Sep 17 00:00:00 2001
From: Elliotte Rusty Harold <elharo@ibiblio.org>
Date: Fri, 19 Dec 2025 08:03:40 -0500
Subject: [PATCH] Better exception handling

---
 .../fromDependencies/RenderDependenciesMojo.java | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/dependency/fromDependencies/RenderDependenciesMojo.java b/src/main/java/org/apache/maven/plugins/dependency/fromDependencies/RenderDependenciesMojo.java
index 6a4291480..00a78b09d 100644
--- a/src/main/java/org/apache/maven/plugins/dependency/fromDependencies/RenderDependenciesMojo.java
+++ b/src/main/java/org/apache/maven/plugins/dependency/fromDependencies/RenderDependenciesMojo.java
@@ -23,6 +23,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.io.StringWriter;
+import java.io.UncheckedIOException;
 import java.io.Writer;
 import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
@@ -154,9 +155,10 @@ protected void doExecute() throws MojoExecutionException {
     }
 
     /**
-     * Do render the template.
-     * @param artifacts input.
-     * @return the template rendered.
+     * Render the template.
+     *
+     * @param artifacts input
+     * @return the template rendered
      */
     private String render(final List<Artifact> artifacts) {
         final Path templatePath = getTemplatePath();
@@ -178,8 +180,7 @@ private String render(final List<Artifact> artifacts) {
         context.put("sorter", new CollectionTool());
 
         // Merge template + context
-        final StringWriter writer = new StringWriter();
-        try (StringWriter ignored = writer) {
+        try (StringWriter writer = new StringWriter()) {
             if (fromFile) {
                 final Template template =
                         ve.getTemplate(templatePath.getFileName().toString());
@@ -187,11 +188,10 @@ private String render(final List<Artifact> artifacts) {
             } else {
                 ve.evaluate(context, writer, "tpl-" + Math.abs(hashCode()), template);
             }
+            return writer.toString();
         } catch (final IOException e) {
-            // no-op, not possible
+            throw new UncheckedIOException("not possible", e);
         }
-
-        return writer.toString();
     }
 
     private Path getTemplatePath() {