Skip to content

Commit 0b469eb

Browse files
committed
Updated modal.js to use ng-class
Instead of using the link function to add a watch that only changes the class list of the dimmer element. Just use ng-class to watch the model instead, then you do not need any code in your link function.
1 parent 7393a45 commit 0b469eb

File tree

1 file changed

+3
-17
lines changed

1 file changed

+3
-17
lines changed

src/modal/modal.js

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,26 +10,12 @@ angular.module('angularify.semantic.modal', [])
1010
scope: {
1111
model: '=ngModel'
1212
},
13-
template: "<div class=\"{{ modal_class }}\">" +
14-
"<div class=\"ui test modal transition visible active\" style=\"margin-top: -189px;\" ng-transclude>" +
13+
template: "<div class=\"ui dimmer page\" ng-class=\"{ active: model }\">" +
14+
"<div class=\"ui test modal transition visible\" style=\"margin-top: -189px;\" ng-transclude>" +
1515
"</div>" +
1616
"</div>",
1717
link: function (scope, element, attrs) {
18-
if (scope.model == true) {
19-
scope.modal_class = 'ui dimmer page active';
20-
} else{
21-
scope.model = false;
22-
scope.modal_class = 'ui dimmer page';
23-
}
24-
25-
scope.$watch('model', function (val) {
26-
if (scope.model == true) {
27-
scope.modal_class = 'ui dimmer page active';
28-
} else{
29-
scope.model = false;
30-
scope.modal_class = 'ui dimmer page';
31-
}
32-
});
18+
3319
}
3420
}
3521
});

0 commit comments

Comments
 (0)