Commit e1ebabe
test(material/chips): prevent unintentional test success (#22920)
In 'MatChipInput' test, `MatInputModule` was not imported and
therefore the `matInput` directive was not interpreted.
If importing `MatInputModule` into the testing module,
the `matInput` directive gets applied and
the test 'MatChipInput basic behavior should be aria-required
if the list is required' would fail because of side effects
by setting the `aria-required` attribute. Obviously,
`matInput` does not remove the `aria-required` attribute,
while the chips implementation is doing so
(chips is interpreting false as null, while `matInput`
leaves 'false' as-is).
(cherry picked from commit 3cd1f52)1 parent 4146af0 commit e1ebabe
File tree
2 files changed
+2
-2
lines changed- src
- material-experimental/mdc-chips
- material/chips
2 files changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | | - | |
| 240 | + | |
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
250 | | - | |
| 250 | + | |
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
| |||
0 commit comments